Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor display issue on Control C if no wipe has been started and one or more drives have been selected. #405

Closed
PartialVolume opened this issue Feb 23, 2022 · 1 comment
Assignees
Labels

Comments

@PartialVolume
Copy link
Collaborator

PartialVolume commented Feb 23, 2022

I just noticed this minor display issue. It doesn't affect the wipe process, it's more to do if you run nwipe then abort using Control C before initiating a wipe. You will only see it on a high resolution monitor with default text mode set at full screen (as in the latest ShredOS), but not in low res 80 x 30 console windows.

First scenario:

You start nwipe then change your mind and type control C to exit. If you have not selected any drives the main window simply turns blue and contains no text. Program exits. There is no summary table or error table, which is to be expected because no wipe was ever started. This is how it should be.

Second scenario: (the issue)

You start nwipe then select one or more drives, unlike in the first scenerio, but you still do not start a wipe, then you Control C to exit. In the main nwipe window, for less than a second, a message appears that says /dev/sdx 100% complete, if you blink you will miss it. Nwipe then exits. Basically a spurious message appears. The last line of the log states that "Nwipe was aborted by the user prior to the wipe starting". There is no summary table or error table, which is to be expected because no wipe was ever started. So the bug is simply that spurious message that flashes onto the screen for less than a second and then disappears saying 100% complete when nothing was ever started. The expected result should be the same as scenario 1. i.e. remove spurious message on control C.

Third scenario:

You start nwipe then select your drives & method, then start the wipe. Change your mind and abort. Main window will correctly show progress up to the point the control C was issued. The summary table says UABORTED (User ABORTED) This is correct and as to be expected.

Summary:

So in summary, a fix is required for the spurious exit message described in the second scenario, while not changing the exit behaviour of the first and third scenarios.

@PartialVolume PartialVolume self-assigned this Feb 23, 2022
@PartialVolume
Copy link
Collaborator Author

Fixed by #406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant