-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Be able to add columns from the "winget show" cli command to the tables #818
Comments
@marticliment |
That is not a bad idea, however I am not sure there would be enough space to show the description in the table. How about showing its description or short description, if available, when hovering a package? |
It all depends on your real estate (how big is your monitor/s), but this is exactly why I want it to be customizable - if a user feels its too crammed, he can hide this tab easily, or the other way, show it in two mouse button clicks. |
I don't think that this would be possible, since even with the implementation of #712, descriptions would also need to be manually loaded, which would make it very slow (we are talking about minutes of loading, not ideal). There's no way to get all descriptions in a single command. |
I don't understand why not making this a feature so the user could add it, and also maybe warn that it can be slow, but still able to have it? You can show some sort of circle next to the row to show that it's updating in the background so the user can have a visible cue for it. Maybe it's good to have some caching for some package info in before coming with the app so that the first load would be fast with these descriptions, and when I am, let's say, highlighting a package, in the background it gets its description and updates it in the UI? Another solution can be opening an issue on https://github.com/microsoft/winget-cli/issues and ask them for the feature on being able to specify multiple packages in single command like: @marticliment What do you say? |
Because it is impossible with the current technology to expect a window to handle 14000+ packages with their descriptions, and not hang every 2 seconds. Also, on those 2-10 minutes of loading, your cpu would be at 100%, a less-than-ideal situation. It is not about not implementing the feature. it is about not being implementable. You can check out https://github.com/DrewNaylor/guinget/releases/tag/v0.3.0.2-beta, which does that, and you will understand what I mean. (not to criticise their amazing job, but the intended behaviour of their approach implies those wait times) Also, this feature would apply only to winget, and not to scoop or chocolatey, what could confuse users |
That would be loaded on demand and maybe could also be extended to Scoop/Chocolatey |
Exactly. As I suggested, you can cache these descriptions easily for the subsequent run of WingetUI so it won't take much long and only will update the description afterwards when:
Eventually I hope this will be implemented correctly into the UI for a great usability. There are ways to make things pretty snappy and not CPU hungry if you do the implementation right. @marticliment your thoughts? |
That would mean 2 out of 3 packages (or even more) would have the No Description tab.
Obviously, things can get optimized to be as efficient as possible, but optimization has limits, and computational power of PCs has improved a lot. For the moment, looking at winget/chocolatey/scoop client capabilities, I don't think this feature is doable in a working, sane way. If you count time, on winget it takes ~5-40secs (they even don't loadat all sometimes) to parse a single description. Just multiply this for 6000 winget packages. However, if the clients change, i'm always open to rethinking any undone feature due to current limitations. |
I still think that WingetUI should be the ultimate manager for all of these package managers, so if one works differently than the other it should be taken into consideration in the code and have its own code path to deal with. But sure, I won't push this one to your throat. |
Before submitting the issue
Is your feature request related to a problem? Please describe.
I would like to specifically add the description column for the table in the "Discover Packages" for a better discoverability of new apps.
Describe the solution you'd like
Be able to right click on the tables in the tabs to add columns from the "winget show {appname}" for example.
For example the description from this:
The text was updated successfully, but these errors were encountered: