Prevent Package Managers from doing certain operations when not enabled or not found (fix #2052)

Author: marticliment

src/UniGetUI.PackageEngine.PackageManagerClasses/Manager/PackageManager.cs

@@ -63,10 +63,8 @@ public virtual async Task InitializeAsync()
             {
                 Status = await LoadManager();
 
-
-                if (SourceProvider != null && Status.Found)
+                if (IsReady() && SourceProvider != null)
                 {
-
                     Task<ManagerSource[]> SourcesTask = GetSources();
                     Task winner = await Task.WhenAny(
                         SourcesTask,
@@ -129,6 +127,15 @@ public bool IsEnabled()
             return !Settings.Get("Disable" + Name);
         }
 
+        /// <summary>
+        /// Returns true if the manager is enabled and available (the required executable files were found). Returns false otherwise
+        /// </summary>
+        /// <returns></returns>
+        public bool IsReady()
+        {
+            return IsEnabled() && Status.Found;
+        }
+
         /// <summary>
         /// Returns an array of Package objects that the manager lists for the given query. Depending on the manager, the list may 
         /// also include similar results. This method is fail-safe and will return an empty array if an error occurs.
@@ -137,6 +144,7 @@ public bool IsEnabled()
         /// <returns></returns>
         public async Task<Package[]> FindPackages(string query)
         {
+            if (!IsReady()) { Logger.Warn($"Manager {Name} is disabled but yet FindPackages was called"); return []; };
             try
             {
                 Package[] packages = await FindPackages_UnSafe(query);
@@ -163,6 +171,7 @@ public async Task<Package[]> FindPackages(string query)
         /// <returns></returns>
         public async Task<Package[]> GetAvailableUpdates()
         {
+            if (!IsReady()) { Logger.Warn($"Manager {Name} is disabled but yet GetAvailableUpdates was called"); return []; };
             try
             {
                 await RefreshPackageIndexes();
@@ -187,6 +196,7 @@ public async Task<Package[]> GetAvailableUpdates()
         /// <returns></returns>
         public async Task<Package[]> GetInstalledPackages()
         {
+            if (!IsReady()) { Logger.Warn($"Manager {Name} is disabled but yet GetInstalledPackages was called"); return []; };
             try
             {
                 Package[] packages = await GetInstalledPackages_UnSafe();
@@ -348,6 +358,7 @@ public OperationVeredict GetRemoveSourceOperationVeredict(ManagerSource source,
         }
         public virtual async Task<ManagerSource[]> GetSources()
         {
+            if (!IsReady()) { Logger.Warn($"Manager {Name} is disabled but yet GetSources was called"); return []; };
             try
             {
                 AssertSourceCompatibility("GetSources");
@@ -381,6 +392,7 @@ private void AssertPackageDetailsCompatibility(string MethodName)
 #pragma warning disable CS8602
         public async Task<PackageDetails> GetPackageDetails(Package package)
         {
+            if (!IsReady()) { Logger.Warn($"Manager {Name} is disabled but yet GetPackageDetails was called"); return new(package); };
             try
             {
                 AssertPackageDetailsCompatibility("GetPackageDetails");
@@ -398,6 +410,7 @@ public async Task<PackageDetails> GetPackageDetails(Package package)
 
         public async Task<string[]> GetPackageVersions(Package package)
         {
+            if (!IsReady()) { Logger.Warn($"Manager {Name} is disabled but yet GetPackageVersions was called"); return []; };
             try
             {
                 AssertPackageDetailsCompatibility("GetPackageVersions");

src/UniGetUI/Interface/Widgets/SourceManager.xaml.cs

@@ -153,7 +153,7 @@ public SourceManager(PackageManager Manager)
 
         public async void LoadSources()
         {
-            if (!Manager.Status.Found)
+            if (!Manager.IsReady())
                 return;
 
             LoadingBar.Visibility = Visibility.Visible;