Skip to content

Commit 1e9af51

Browse files
committed
Adjust FK code for cockroach according to DB
1 parent 94036f4 commit 1e9af51

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,3 @@ migrations/schema.sql
3232
.grifter/
3333
cockroach-data/
3434
vendor/
35-
cockroach-data/

fizz/translators/cockroach.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ func (p *Cockroach) colType(c fizz.Column) string {
382382

383383
func (p *Cockroach) buildForeignKey(t fizz.Table, fk fizz.ForeignKey, onCreate bool) string {
384384
refs := fmt.Sprintf("%s (%s)", fk.References.Table, strings.Join(fk.References.Columns, ", "))
385-
s := fmt.Sprintf("FOREIGN KEY (%s) REFERENCES %s", fk.Column, refs)
385+
s := fmt.Sprintf("CONSTRAINT %s FOREIGN KEY (%s) REFERENCES %s", fk.Name, fk.Column, refs)
386386

387387
if onUpdate, ok := fk.Options["on_update"]; ok {
388388
s += fmt.Sprintf(" ON UPDATE %s", onUpdate)
@@ -393,7 +393,7 @@ func (p *Cockroach) buildForeignKey(t fizz.Table, fk fizz.ForeignKey, onCreate b
393393
}
394394

395395
if !onCreate {
396-
s = fmt.Sprintf("ALTER TABLE %s ADD CONSTRAINT %s %s;COMMIT TRANSACTION;BEGIN TRANSACTION;", t.Name, fk.Name, s)
396+
s = fmt.Sprintf("ALTER TABLE %s ADD %s;COMMIT TRANSACTION;BEGIN TRANSACTION;", t.Name, s)
397397
}
398398

399399
return s

fizz/translators/cockroach_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ CREATE TABLE "profiles" (
9898
"last_name" VARCHAR (255) NOT NULL,
9999
"created_at" timestamp NOT NULL,
100100
"updated_at" timestamp NOT NULL,
101-
FOREIGN KEY (user_id) REFERENCES users (id)
101+
CONSTRAINT profiles_users_id_fk FOREIGN KEY (user_id) REFERENCES users (id)
102102
);COMMIT TRANSACTION;BEGIN TRANSACTION;`
103103

104104
res, _ := fizz.AString(`

0 commit comments

Comments
 (0)