Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostCSS meta plugin cannot parse important comments #74

Closed
yhatt opened this issue Sep 19, 2018 · 0 comments
Closed

PostCSS meta plugin cannot parse important comments #74

yhatt opened this issue Sep 19, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@yhatt
Copy link
Member

yhatt commented Sep 19, 2018

Regardless of the description on document, this metadata in the CSS is not recognized and throw error when calling ThemeSet.add().

/*! @theme foobar */

The beginning special chars ! is not considered in Marpit PostCSS meta plugin.

marpit/src/postcss/meta.js

Line 18 in 1e18258

/^[*\s]*@([a-z][a-z0-9]*)\s+(.+)$/gim,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yhatt