Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define whether supports a virtual workspace #224

Closed
yhatt opened this issue May 5, 2021 · 0 comments · Fixed by #225
Closed

Define whether supports a virtual workspace #224

yhatt opened this issue May 5, 2021 · 0 comments · Fixed by #225

Comments

@yhatt
Copy link
Member

yhatt commented May 5, 2021

https://code.visualstudio.com/updates/v1_56#_define-whether-your-extension-supports-a-virtual-workspace

Call to Action: Please check whether your extension can handle virtual workspaces, and set the virtualWorkspaces capability accordingly in your package.json.

For supporting virtual workspace

➡️ #225

Memo

Marp extension is still using Node.js fs. It would be resolved by replacing to use VS Code workspace API.

The core problem is that slide export is depending on Marp CLI and it's using fs internally. It requires to change Marp CLI API, to accept alternative fs module.

Even so, exports depending on Puppeteer are not working because Chrome browser won't recognize files in VS Code virtual workspace. We may have to restrict export type to HTML export when the extension is working on a virtual workspace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant