Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last slide visually shifted in HTML export #101

Closed
badcat opened this issue Nov 15, 2019 · 2 comments · Fixed by #106
Closed

Last slide visually shifted in HTML export #101

badcat opened this issue Nov 15, 2019 · 2 comments · Fixed by #106
Labels
bug Something isn't working

Comments

@badcat
Copy link

badcat commented Nov 15, 2019

Really love marp for vscode - Thank you.

I noticed that the last slide on the generated HTML export is always slightly shifted vertically in the browser. It looks lke the "Marp Core's Browser" JS is getting put inside the last slide's SVG. If the JS was moved outside the last SVG (perhaps just before the closing body tag), then the preview appears correct without any visual position shifting.

tested on:
macOS 10.14 - Chrome latest, Safari 13.0.2, Firefox 70.0.1

Example MD and HTML attached:
marp-shift.zip

@yhatt
Copy link
Member

yhatt commented Nov 16, 2019

Thanks for your catching of details.

JS injection to the last SVG slide has implemented in recent Marp Core. This behavior is for dealing with Marp CLI's bug reported by power-user (marp-team/marp-cli#168), but it seems to get small visual regression as you see (VS Code preview is disabled this injection so would make clear the difference).

I'm sure moving <script> to the outside of SVG would work fine, but we have to improve architectures of Marp ecosystem to get it.

@yhatt
Copy link
Member

yhatt commented Nov 18, 2019

Fixed in v0.11.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants