Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reliability of connection to Chrome process #395

Closed
yhatt opened this issue Oct 25, 2021 · 3 comments · Fixed by #400
Closed

Improve reliability of connection to Chrome process #395

yhatt opened this issue Oct 25, 2021 · 3 comments · Fixed by #400

Comments

@yhatt
Copy link
Member

yhatt commented Oct 25, 2021

Related: marp-team/marp#165, marp-team/marp#198, puppeteer/puppeteer#6258

We have received some reports about the error thrown Target.setDiscoverTargets by Puppeteer. We can try to improve making connection to the spawned Chrome.

Possible workarounds

  • If failed making connection with Chrome in pipe: true option, we can try to launch Chrome again with pipe: false for making connection through WebSocket instead of pipe.
@yhatt yhatt changed the title Improve reliability to connect to Chrome process Improve reliability of connection to Chrome process Oct 25, 2021
@amir734jj
Copy link

amir734jj commented Nov 4, 2021

Any timeline frame for this release? I will be teaching a class in February and I really like to utilize this feature.

@yhatt
Copy link
Member Author

yhatt commented Nov 4, 2021

It would be included in the next patch release that will be shipped in a month a week. A monthly patch for Marp CLI is just delayed now because I'm currently working on Marpit v3 and Marp Core v3.

@amir734jj
Copy link

Thank you so much for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants