Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presenter notes are not applied to PPTX correctly #346

Closed
yhatt opened this issue May 11, 2021 · 3 comments · Fixed by #347
Closed

Presenter notes are not applied to PPTX correctly #346

yhatt opened this issue May 11, 2021 · 3 comments · Fixed by #347
Labels
bug Something isn't working upstream Caused in upstream, not in this repo

Comments

@yhatt
Copy link
Member

yhatt commented May 11, 2021

Reported in marp-team/marp-vscode#229.

Hi, I added some comments to my .md document in VSCode:

# Classes and Interfaces

1. What features of ***Object Orientation*** are there?

<!-- Notes? -->

It seems like Marp does try to collect these and put them into the powerpoint in the right format, but unfortunately doesn't unwrap them from the array data structure into a string

https://marpit.marp.app/usage?id=presenter-notes

Screenshot 2021-05-11 at 16 54 30
@yhatt yhatt added the bug Something isn't working label May 11, 2021
@djmcgreal-cc
Copy link

Thanks, I did a binary search and found it regressed in v0.18.0 so I'm now using 0.17.3 and can conduct my first Zoom based interview tomorrow morning :)
Dan.

@yhatt
Copy link
Member Author

yhatt commented May 11, 2021

@djmcgreal-cc Sorry for inconvenience!

@yhatt
Copy link
Member Author

yhatt commented May 11, 2021

I've found it's a bug by the upstream library PptxGenJS v3.5.0: gitbrent/PptxGenJS#941

npx @marp-team/marp-cli --pptx markdown.md will use the latest PptxGenJS v3.6.0 so this problem will not occur.

@yhatt yhatt added the upstream Caused in upstream, not in this repo label May 11, 2021
@yhatt yhatt mentioned this issue May 11, 2021
Merged
1 task
@yhatt yhatt mentioned this issue May 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream Caused in upstream, not in this repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade dependent packages to the latest version marp-team/marp-cli
2 participants
@yhatt @djmcgreal-cc