Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build linux/arm64 container images in addition to the linux/amd64 ones #328

Closed
spkane opened this issue Mar 4, 2021 · 4 comments · Fixed by #339
Closed

Build linux/arm64 container images in addition to the linux/amd64 ones #328

spkane opened this issue Mar 4, 2021 · 4 comments · Fixed by #339
Labels
enhancement New feature or request

Comments

@spkane
Copy link

spkane commented Mar 4, 2021

This will help support folks on things like Raspberry Pis and Apple Silicon Macs.
@spkane
Copy link
Author

spkane commented Mar 4, 2021

Images could be tagged something like amd64-v0.23.2 and arm64-v0.23.2

@yhatt yhatt added the enhancement New feature or request label Mar 4, 2021
@spkane
Copy link
Author

spkane commented Mar 13, 2021

Note, that I have tried building the Dockerfile on my Apple Silicon Mac and so far that seems to work just fine without any changes. Docker pulls the node base image for the correct arch, and so far, so good.

@yhatt yhatt mentioned this issue Apr 24, 2021
Merged
@yhatt
Copy link
Member

yhatt commented Apr 24, 2021

Now we've set up automated build for multi-arch images including ARM64 by working in #339.

But currently it makes over 3x slower to build because using ARM emulation on x64 environment in CircleCI.

@spkane
Copy link
Author

spkane commented May 29, 2021

Thank you @yhatt! I just switched off my custom build image and tested this out today and it appears to be working great.

@yhatt yhatt mentioned this issue Nov 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build Docker container image for ARM64 marp-team/marp-cli
2 participants
@spkane @yhatt