Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better custom Chrome path support in WSL #288

Closed
yhatt opened this issue Sep 17, 2020 · 0 comments · Fixed by #292
Closed

Better custom Chrome path support in WSL #288

yhatt opened this issue Sep 17, 2020 · 0 comments · Fixed by #292

Comments

@yhatt
Copy link
Member

yhatt commented Sep 17, 2020

When Marp CLI is running on WSL, currently it will always expect to use Chrome located on the host Windows. Using custom chrome path set by CHROME_PATH env is still work, but it may bring mismatch of path style for temporary files and directories between Windows and POSIX. For example, the profile directory for Puppetter will be created with Windows style path, when setting chrome path to Chrome hosted on Linux.

Determining which OS running on from detected Chrome path is better than the current logic. Especially WSL2 cannot use Windows Chrome for now, so user must rely to custom Chrome path setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant