Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit better error message when there is not a compatible browser #220

Closed
yhatt opened this issue Apr 21, 2020 · 0 comments · Fixed by #234
Closed

Emit better error message when there is not a compatible browser #220

yhatt opened this issue Apr 21, 2020 · 0 comments · Fixed by #234
Labels
enhancement New feature or request

Comments

@yhatt
Copy link
Member

yhatt commented Apr 21, 2020

Continued from #219.

When chrome-launcher cannot find out the executable Chrome, Marp CLI should be better to emit the error message to advise installing Google Chrome.

The current error message Could not find browser revision 737027. Run "npm install" or "yarn install" to download a browser binary. will cause misleading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Puppetter utility based on several reports marp-team/marp-cli
1 participant
@yhatt