-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to Microsoft Edge if not installed Chrome #199
Comments
Isn't it work of chrome-launcher package? CLI just uses path from launcher: marp-cli/src/utils/puppeteer.ts Line 75 in 003fb6b
|
@ShGKme chrome-launcher is only designed for Google Chrome and Chromium, not for Chromium-flavored browsers such as Edge. |
@yhatt But if If it's not work for I may do a PR if this solution is ok. |
In short term the limited fallback to Edge in Windows would be no problem. However, eventually we have to use (or create) Chromium Edge finder for Windows, macOS, and Linux as same as |
Edge is default only on Windows. I thought, the idea was that windows users should be able to use already installed Edge without any actions as it is. Just because it works and the browser is already installed. If any user has a normally installed Chrome, it would be found by Right now Edge has only 1 (ok, +1 more for Beta version) place to be installed by default in Windows ( Of course, another way is to use some 3rd package, which would found any chromium-based browser on any OS. And add cli arg for choose like in Cypress. |
Here is the one of reliable way to resolve the executable path of Edge, by Microsoft (microsoft/vscode-edge-devtools): |
Microsoft has started rolling out new Edge browser based on Chromium. It will gradually be made available on Windows Update.
This fact is lucky for Marp CLI. PDF/PPTX conversion and preview mode has to install an extra Chrome/Chromium browser. Currently, it also works with Edge by setting
CHROME_PATH
environment variable.It means the most of Windows 10 user will get the compatible browser without to do anything by user. If Marp CLI was supported fallback to Edge, installing extra browser won't be needed when converting Markdown into PDF/PPTX.
The text was updated successfully, but these errors were encountered: