Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change port number for sending reload signal in watch mode #135

Closed
2 tasks done
yhatt opened this issue Aug 20, 2019 · 0 comments · Fixed by #137
Closed
2 tasks done

Change port number for sending reload signal in watch mode #135

yhatt opened this issue Aug 20, 2019 · 0 comments · Fixed by #137

Comments

@yhatt
Copy link
Member

yhatt commented Aug 20, 2019

portfinder's breaking reported in #134 was an unexpected trouble, but it tells us to prevent using port number > 40000. That has a good reason exaplined at http-party/node-portfinder#82 (comment).

Marp CLI is using 52000 port resolved by portfinder. We think it would be deprecated soon. So we have to change the base port for sending signals.

ToDo

  • Change base port number for sending reload signal in watch mode to < 40000
  • Update description of Docker Hub to change binding port
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant