Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

title type mismatch between ListProps and EditProps, CreateProps, ShowProps #6350

Closed
megantaylor opened this issue Jun 10, 2021 · 1 comment · Fixed by #6351
Closed

title type mismatch between ListProps and EditProps, CreateProps, ShowProps #6350

megantaylor opened this issue Jun 10, 2021 · 1 comment · Fixed by #6351

Comments

@megantaylor
Copy link
Contributor

seems like in #6119, false was added as a possible type for title in ListProps.

For such cases, we should add a support for false value in the <Title> component, which wouldn't create a portal in that case

Originally posted by @fzaninotto in #6119 (comment)

but it was not added for EditProps, CreateProps, ShowProps, which causes a type mismatch error.

Can false be added a possible type for title for those components?
@djhi
Copy link
Collaborator

djhi commented Jun 10, 2021

Make sense. Thanks for bringing that up. Can you open a PR?

@megantaylor megantaylor mentioned this issue Jun 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TypeScript] Fix type mismatch error on title prop for page components megantaylor/react-admin
2 participants
@megantaylor @djhi