Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing children to ListAction component #6212

Closed
WiXSL opened this issue Apr 26, 2021 · 2 comments
Closed

Allow passing children to ListAction component #6212

WiXSL opened this issue Apr 26, 2021 · 2 comments

Comments

@WiXSL
Copy link
Contributor

WiXSL commented Apr 26, 2021

In order to add custom actions to the List component, one has to replace the entire default ´ListActions´ component with something else.

Couldn't it be possible to re-use react-admin's ListActions component and pass children to it?

@WiXSL WiXSL changed the title Allow children to ListAction component Allow passing children to ListAction component Apr 26, 2021
@fzaninotto
Copy link
Member

As explained in #6218, I don't think this is a good idea. I agree that the current way of overriding the List actions isn't very user friendly, but the solution that you propose isn't a clear win and brings confusion.

@fzaninotto
Copy link
Member

Fixe by #6218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@fzaninotto @djhi @WiXSL and others