Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datepicker throws error, decrements on clicking dropdown #1326

Closed
jamespsterling opened this issue Mar 20, 2017 · 11 comments
Closed

datepicker throws error, decrements on clicking dropdown #1326

jamespsterling opened this issue Mar 20, 2017 · 11 comments
Assignees
Labels

Comments

@jamespsterling
Copy link

jamespsterling commented Mar 20, 2017

Datepicker changes after selecting date from the picker and click into another field on the form.

Running latest version of master as of 3/20/2017

Steps to Reproduce

  1. Goto: https://marmelab.com/ng-admin-demo/index.html#/customers/edit/485
  2. Click into the datepicker 'Birthday' field
  3. Select any date
  4. Click into another input field on the form (any)
  5. Observe as clicking into any other field changes the date in the 'Birthday' input field

Expected behavior:
Datepicker input to not change

Actual behavior:
Datepicker input changes when clicking into another input field

GIF Demo:
ng-admin-datepicker-strangeness

console.log.txt

@Kmaschta
Copy link
Contributor

On which timezone do you are?

@jamespsterling
Copy link
Author

jamespsterling commented Mar 21, 2017

@Kmaschta EST

@dlemphers
Copy link

dlemphers commented Mar 28, 2017

@Kmaschta I'm experiencing the same, and in the debug console I get a:

10 $digest() iterations reached. Aborting! error.

My TZ is USA/CST

If I clear the date field first, then it works. Also, it works on create, but errors on edit.

@Kmaschta
Copy link
Contributor

Kmaschta commented Apr 5, 2017

@jamespsterling @dlemphers Do you confirm that the PR #1334 has fixed this issue?

@dlemphers
Copy link

@Kmaschta I'm on 1.0.5 and I still have issues:

  1. The date shown in the input box is correct, but when you select the popout, the date is the day before:

image

  1. At this point if I select a new value, I get the 10 $digest() iterations reached error:

image

  1. And lastly, clicking on the dropdown changes the date by itself, decrementing 11 days at a time. For example, I just click on the calendar icon, then click off focus without selecting a date, and repeat that, and the date just changes by itself.

image

image

image

image

@marceloodjusto
Copy link

marceloodjusto commented Aug 7, 2017

Has this problem been fixed?? I have the same problem here.
Is there any other alternative to date fields?

@renanrv
Copy link

renanrv commented Aug 9, 2017

Same problem here.

@amitstein
Copy link

I guess that the cause of this bug is when the date is created from a string that only contain the date part (not the time)


Since it is created from UTC time, so with negative timezone offsets the date resulted it's the day before.
So, after that it starts an infinite loop between the watches of values and rawValue

@thanhbuiea
Copy link

Any progress on this bug? It has been present for more than a while.

@Kmaschta
Copy link
Contributor

@thanhbuiea I'm sorry, but we are focusing our efforts in a new project: marmelab/react-admin, and we haven't the time to address all the ng-admin issues.

But we'd be glad to help any contribution.

@sarvaniupadrasta
Copy link

@here Issue is not reproducible now. This can be closed

@Kmaschta Kmaschta closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants