Skip to content

Commit d0ea86a

Browse files
Edsunsalshedivat
andauthored
Optimize dark theme (alshedivat#431)
* Optimize dark theme * Fix-up * Minor fixes Co-authored-by: Maruan Al-Shedivat <[email protected]>
1 parent 55b77d0 commit d0ea86a

File tree

3 files changed

+19
-10
lines changed

3 files changed

+19
-10
lines changed

_sass/_base.scss

+16-8
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ p, h1, h2, h3, h4, h5, h6, em, div, li, span, strong {
88
color: var(--global-text-color);
99
}
1010

11+
hr {
12+
border-top: 1px solid var(--global-divider-color);
13+
}
14+
1115
a, table.table a {
1216
color: var(--global-theme-color);
1317
&:hover {
@@ -91,18 +95,22 @@ blockquote {
9195

9296
.navbar {
9397
box-shadow: none;
94-
border-bottom: 1px solid $grey-color-light;
98+
border-bottom: 1px solid var(--global-divider-color);
9599
background-color: var(--global-bg-color);
96100
opacity: 0.95;
97101
}
98102
.navbar .dropdown-menu {
99103
background-color: var(--global-bg-color);
104+
border: 1px solid var(--global-divider-color);
100105
a:not(.active) {
101106
color: var(--global-text-color);
102107
}
103108
a:hover {
104109
color: var(--global-hover-color);
105110
}
111+
.dropdown-divider {
112+
border-top: 1px solid var(--global-divider-color) !important;
113+
}
106114
}
107115
.dropdown-item {
108116
color: var(--global-text-color);
@@ -242,7 +250,7 @@ footer.fixed-bottom {
242250
}
243251

244252
footer.sticky-bottom {
245-
border-top: 1px solid $grey-color-light;
253+
border-top: 1px solid var(--global-divider-color);
246254
padding-top: 40px;
247255
padding-bottom: 40px;
248256
font-size: 0.9rem;
@@ -252,7 +260,7 @@ footer.sticky-bottom {
252260
// Blog
253261

254262
.header-bar {
255-
border-bottom: 1px solid $grey-color-light;
263+
border-bottom: 1px solid var(--global-divider-color);
256264
text-align: center;
257265
padding-top: 2rem;
258266
padding-bottom: 5rem;
@@ -267,7 +275,7 @@ footer.sticky-bottom {
267275
margin-bottom: 40px;
268276
padding: 0;
269277
li {
270-
border-bottom: 1px solid $grey-color-light;
278+
border-bottom: 1px solid var(--global-divider-color);
271279
list-style: none;
272280
padding-top: 2rem;
273281
padding-bottom: 2rem;
@@ -358,8 +366,8 @@ footer.sticky-bottom {
358366
}
359367

360368
h2.category {
361-
color: $grey-color-light;
362-
border-bottom: 1px solid $grey-color-light;
369+
color: var(--global-divider-color);
370+
border-bottom: 1px solid var(--global-divider-color);
363371
padding-top: 0.5rem;
364372
margin-top: 2rem;
365373
margin-bottom: 1rem;
@@ -386,8 +394,8 @@ footer.sticky-bottom {
386394
}
387395
}
388396
h2.year {
389-
color: $grey-color-light;
390-
border-top: 1px solid $grey-color-light;
397+
color: var(--global-divider-color);
398+
border-top: 1px solid var(--global-divider-color);
391399
padding-top: 1rem;
392400
margin-top: 2rem;
393401
margin-bottom: -2rem;

_sass/_themes.scss

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
--global-footer-text-color: #{$grey-color-light};
1414
--global-footer-link-color: #{$white-color};
1515
--global-distill-app-color: #{$grey-color};
16+
--global-divider-color: rgba(0,0,0,.1);
1617

1718
.fa-sun {
1819
display : none;
@@ -35,6 +36,7 @@ html[data-theme='dark'] {
3536
--global-footer-text-color: #{$grey-color-dark};
3637
--global-footer-link-color: #{$black-color};
3738
--global-distill-app-color: #{$grey-color-light};
39+
--global-divider-color: #424246;
3840

3941
.fa-sun {
4042
padding-left: 10px;

_sass/_variables.scss

+1-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ $yellow-color: #efcc00 !default;
2525

2626
$grey-color: #828282 !default;
2727
$grey-color-light: lighten($grey-color, 40%);
28-
$grey-color-dark: darken($grey-color, 25%);
28+
$grey-color-dark: #1C1C1D;
2929

3030
$white-color: #ffffff !default;
3131
$black-color: #000000 !default;
@@ -35,4 +35,3 @@ $black-color: #000000 !default;
3535

3636
$code-bg-color-light: rgba($purple-color, 0.05);
3737
$code-bg-color-dark: #2c3237 !default;
38-

0 commit comments

Comments
 (0)