Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report linting of an entire project via the github status API #70

Open
adrianmoisey opened this issue Oct 16, 2015 · 7 comments
Open

Report linting of an entire project via the github status API #70

adrianmoisey opened this issue Oct 16, 2015 · 7 comments

Comments

@adrianmoisey
Copy link
Contributor

It would be nice if the result of a linting of the entire project is reported to the github status api (https://github.com/blog/1227-commit-status-api).
Then there should be an option to allow this call to fail if there are more then n linting issues

@markstory
Copy link
Owner

Sounds pretty useful.

@adrianmoisey
Copy link
Contributor Author

The pygithub3 package is blocking this, as it doesn't support that endpoint yet.

@minichate
Copy link
Contributor

https://github.com/sigmavirus24/github3.py supports the statuses API. I'm going to take a crack at implementing this

@adrianmoisey
Copy link
Contributor Author

It's already been done, thanks though.
See #74 and #77

@adrianmoisey
Copy link
Contributor Author

My plan for this issue was to use the status endpoint for a report of the entire project's linting. @markstory do you think that's a good one to add?

@markstory
Copy link
Owner

@adrianmoisey How would that work? So much of lintreview is focused on pul requests right now?

@adrianmoisey
Copy link
Contributor Author

I'm not too sure really. Let me hack away and see if I can get it working, I imagine it won't be too hard. Then you can decide if it's useful.

@adrianmoisey adrianmoisey reopened this Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants