Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F401 not within diffs #35

Open
zoidyzoidzoid opened this issue Sep 22, 2014 · 1 comment
Open

F401 not within diffs #35

zoidyzoidzoid opened this issue Sep 22, 2014 · 1 comment

Comments

@zoidyzoidzoid
Copy link
Contributor

I recently had a commit where I removed some code, which then ended up causing an F401(Unused import), which fell outside the diff.

It would be nice to still comment on the PR that the changes caused the unused import.

It would be complicated to determine that the unused import was caused by this diff, but I think it might be okay to assume that before the PR the files had no unused imports.

@markstory
Copy link
Owner

That will be tricky for sure, outside of special casing python linters and analyzing the entire file I don't know how it would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants