fix: non leading-tabs in markdown content (#1559)

[rossipedia]

Marked version:

Markdown flavor: CommonMark

Description

Only replaces tabs at the beginning of a block construct. Tabs in the middle of the item are unaffected.

• Fixes Markdown containing tabs not converted properly to spaces #1559 (if fixing a known issue; otherwise, describe issue using the following format)

Contributor

• Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
• no tests required for this PR.
• If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

• CI is green (no forced merge required).
• Squash and Merge PR following conventional commit guidelines.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marked-website – ./

🔍 Inspect: https://vercel.com/markedjs/marked-website/D3uTfybfhra66Kx3bbv8kgdEqMw5
✅ Preview: https://marked-website-git-fork-docker-fix-commonmark-tabs-markedjs.vercel.app

markedjs – ./

🔍 Inspect: https://vercel.com/markedjs-legacy/markedjs/A1UvPUv6aE5erAJmpiDKM5my7xeg
✅ Preview: https://markedjs-git-fork-docker-fix-commonmark-tabs-markedjs-legacy.vercel.app

[rossipedia]

Does this look good now?

[UziTech]

Thanks for fixing this! 💯

[calculuschild]

Looks good to me. Only question is if there might be some other token that needs its rules.js updated to handle tabs?

[UziTech]

I did find one example that seems broken.

>	test
// tab between > and test

It is actually currently kind of broken (additional spaces are added to the output) but with this PR it creates a code element in the blockquote.

Looks like https://github.com/markedjs/marked/blob/master/src/Tokenizer.js#L154 might have to be updated to remove a tab after > as well.

[rossipedia]

Ok seems like that might be a case that's missing a test. I'll see about putting one together for it.

[UziTech]

@calculuschild I think this now passes any test I can think of.

[calculuschild]

Cool, I approve then. I can't think of anything else either.

[github-actions]

🎉 This PR is included in version 4.0.14 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀