Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing ![]() is buggy #1456

Closed
jackens opened this issue Mar 28, 2019 · 4 comments
Closed

Parsing ![]() is buggy #1456

jackens opened this issue Mar 28, 2019 · 4 comments
Labels
category: images L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue

Comments

@jackens
Copy link

jackens commented Mar 28, 2019

Describe the bug
Parsing ![]() is buggy

To Reproduce

![](img1.svg) (or ![](img2.svg))

generates

<p><img src="img1.svg" alt="" title="or ![](img2.svg">)</p>

(conf. https://marked.js.org/demo/?text=![](img1.svg)%20(or%20![](img2.svg)))

Expected behavior

<p><img src="img1.svg" alt=""> (or <img src="img2.svg" alt="">)</p>
@styfle styfle added category: images L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue labels Mar 29, 2019
@UziTech
Copy link
Member

UziTech commented Mar 29, 2019 •
edited
Loading

This should be fixed in #1435

demo

@UziTech
Copy link
Member

UziTech commented Mar 29, 2019

I'm not sure why the demo's master isn't working since #1435 was already merged, but this is already fixed in master.

@UziTech UziTech mentioned this issue Mar 29, 2019
Merged
4 tasks
@UziTech
Copy link
Member

UziTech commented Mar 29, 2019

demo master should be fixed in #1457

@UziTech
Copy link
Member

UziTech commented May 3, 2019

This should be fixed in v0.6.2 demo

@UziTech UziTech closed this as completed May 3, 2019
@jackens jackens mentioned this issue Oct 3, 2019
Closed
@robatwilliams robatwilliams mentioned this issue Oct 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: images L1 - broken Valid usage causes incorrect output OR a crash AND there is no known workaround for the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@UziTech @styfle @jackens