Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xss vulnerability in demo page #1294

Closed
UziTech opened this issue Jun 23, 2018 · 5 comments
Closed

xss vulnerability in demo page #1294

UziTech opened this issue Jun 23, 2018 · 5 comments
Labels
category: docs Documentation changes L0 - security A security vulnerability within the Marked library is discovered

Comments

@UziTech
Copy link
Member

UziTech commented Jun 23, 2018

Describe the bug

Our demo page allows xss

We should try to mitigate this similar to commonmark's demo page

We should also have a disclaimer in our documentation about possible xss vulnerability with displaying unsanitized output

related #1232

To Reproduce
Steps to reproduce the behavior:

  1. goto the demo
  2. click one of the links

Expected behavior
Javascript should not execute

@UziTech UziTech added L0 - security A security vulnerability within the Marked library is discovered category: docs Documentation changes labels Jun 23, 2018
@lirantal
Copy link

@UziTech the report is not disclosed so only you and another person are able to access it.
Will you please also add the security notice to the README?

@joshbruce
Copy link
Member

@davisjam to @lirantal's point, what is the standard practice regarding reporting this kind of thing?

This XSS is not on the Marked library - it is on a site we own and provide as a service to users and as a marketing tool. Therefore, we, the committers, are the ones running accept/mitigate/etc. against the vulnerability.

This is also fixed by #1295; so, I don't think we need to update the README - just want to know what the the MO is.

@UziTech
Copy link
Member Author

UziTech commented Jun 26, 2018

@joshbruce this was reported on hackerone.com and I was invited to review the report. The README notice is to remind people using marked from NPM that marked does not sanitize output by default and that displaying user generated markdown can be dangerous.

@styfle
Copy link
Member

styfle commented Jul 9, 2018

@uk1free Hi Mark Murray, we appreciate that your are following the development of marked but please do not spam our issue tracker :octocat:

When you reply to the email from GitHub, your message is sent to 400 people watching this repository and it is a waste of time for 400 people to view a message that says "M".

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs Documentation changes L0 - security A security vulnerability within the Marked library is discovered
Projects
None yet
Development

No branches or pull requests

5 participants
@UziTech @styfle @lirantal @joshbruce and others