Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add S/P amplitude capability to HashPype methods #1

Open
markcwill opened this issue Nov 19, 2013 · 5 comments
Open

Add S/P amplitude capability to HashPype methods #1

markcwill opened this issue Nov 19, 2013 · 5 comments

Comments

@markcwill
Copy link
Owner

Need to do two main things:

  1. Add compiler directives for the Fortran source file containing these subroutines
  2. Add some methods to the HashPype class, probably based on one of the "hash_driver" scripts that use this capability.
@megies
Copy link

megies commented May 8, 2018

Hey @markcwill, you never got round to adding amplitudes, looks like?

@markcwill
Copy link
Owner Author

@megies, I did, check the dev_curds branch, we actually develop this in house; this is a mirror now, needs updating bad, I'll see if I can do it today... pretty sure I ripped out every 3rd party dep "extra" feature, and we have a 1.0 of this

@markcwill
Copy link
Owner Author

@megies, just pushed my current branch, nextgen, and tags up to 1.0-beta. Basicially, we broke out our database and plotting to separate modules, because they had nothing to do with the core func here.

Check in tests/test_io_obspy.py for our basic current workflow, there are a few esoteric things we stick in QuakeML, but I've tried to clean it up a bit.

For S/P amplitudes, the two methods now take a use_amplitudes kwarg that will use the "amp" Fortran routines, but the user is responsible for loading that amp data into the proper arrays, there are no helper methods to do it right now.

@megies
Copy link

megies commented May 9, 2018

I did, check the dev_curds branch, we actually develop this in house

Oh nice, and thanks for the insta-feedback.

user is responsible for loading that amp data into the proper arrays, there are no helper methods to do it right now.

Yeah, I was wondering how you'd even do this real canonically with QuakeML/obspy event classes. That might need some serious thinking how to best do this according to standards.. but it might be worth doing so in the long run.

Right now, I'm gonna see how focmec does with amp ratios, but after that I think I'll try what you got there.

@markcwill
Copy link
Owner Author

Cool, keep me posted. You're right, no straightforward way in QuakeML from Origin, but there are Amplitudes; this isn't on my roadmap, but the first stab I would take is just having a list of Event Amplitudes with type="S/P" or something, (similar to how I check for "p" in Arrival phase). Then we could add it to the obspy io in here. At least that would be better than "load it into the numpy array yourself" which is the only way now.

Maybe a helper func to scan Arrivals/Picks/Amplitudes and create these "S/P" Amplitudes could be part of a separate utility in Obspy? since it's not really specific to this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants