fix expect_inputs and promise_outputs with non-Interactify classes

Author: markburns

lib/interactify/rspec/matchers.rb

@@ -6,7 +6,9 @@
 
 RSpec::Matchers.define :expect_inputs do |*expected_inputs|
   match do |actual|
-    actual_inputs = actual.expected_keys
+    next false unless actual.respond_to?(:expected_keys)
+
+    actual_inputs = Array(actual.expected_keys)
     @missing_inputs = expected_inputs - actual_inputs
     @extra_inputs = actual_inputs - expected_inputs
 
@@ -25,7 +27,9 @@
 # e.g. expect(described_class).to promise_outputs(:request_logger)
 RSpec::Matchers.define :promise_outputs do |*expected_outputs|
   match do |actual|
-    actual_outputs = actual.promised_keys
+    next false unless actual.respond_to?(:promised_keys)
+
+    actual_outputs = Array(actual.promised_keys)
     @missing_outputs = expected_outputs - actual_outputs
     @extra_outputs = actual_outputs - expected_outputs
 

spec/lib/interactify/rspec/matchers_spec.rb

@@ -0,0 +1,58 @@
+require 'interactify/rspec/matchers'
+
+RSpec.describe 'rspec matchers' do
+  describe 'expect_inputs' do
+    it 'passes when the inputs are correct' do
+      expect(k(:A)).to expect_inputs(:a)
+      expect(k(:A)).not_to expect_inputs(:b)
+
+      expect(k(:B)).to expect_inputs(:b)
+      expect(k(:B)).not_to expect_inputs(:a)
+
+      expect(k(:P)).not_to expect_inputs(:a, :b)
+    end
+
+    it 'works with vanilla interactors without blowing up' do
+      expect(k(:Vanilla)).not_to expect_inputs(:a)
+    end
+  end
+
+  describe 'promise_outputs' do
+    it 'passes when the outputs are correct' do
+      expect(k(:A)).not_to promise_outputs(:a)
+      expect(k(:A)).not_to promise_outputs(:a)
+
+      expect(k(:P)).to promise_outputs(:a, :b, :c)
+    end
+
+    it 'works with vanilla interactors without blowing up' do
+      expect(k(:Vanilla)).not_to promise_outputs(:a)
+    end
+  end
+
+
+  module self::SomeNamespace
+    Vanilla = Class.new do
+      include Interactor
+    end
+
+    A = Class.new do
+      include Interactify
+      expect :a
+    end
+
+    B = Class.new do
+      include Interactify
+      expect :b
+    end
+
+    P = Class.new do
+      include Interactify
+      promise :a, :b, :c
+    end
+  end
+
+  def k(klass)
+    self.class::SomeNamespace.const_get(klass)
+  end
+end