Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Output Window when debugging #70

Open
jasc2v8 opened this issue Mar 11, 2021 · 5 comments · Fixed by #507
Open

Disable Output Window when debugging #70

jasc2v8 opened this issue Mar 11, 2021 · 5 comments · Fixed by #507
Assignees
Labels
debugger issues with debugging code enhancement new feature or request

Comments

@jasc2v8
Copy link

jasc2v8 commented Mar 11, 2021

Please add "Disable Output Window".
This will prevent the Output Window from opening upon an AHK run error.
The user can always Ctrl+Shift+U to open the output window.
Thank you.

@mark-wiemer
Copy link
Member

This shouldn't be too tough to implement, but it's not the highest priority. Just posting an update here as #492 was just opened as a dupe. This is still very possible and in-scope, but with ~40 issues backlogged and a personal vacation coming up, I can't guarantee it'll be solved this month. I'll be working on reordering the backlog found at the AHK++ project if you'd like to see where my priorities lie :)

@mark-wiemer mark-wiemer moved this from Todo to In Progress in AHK++ Sep 18, 2024
@mark-wiemer mark-wiemer added the debugger issues with debugging code label Sep 19, 2024
mark-wiemer added a commit that referenced this issue Sep 20, 2024
* Fixup license

* Sort Chinese nls

* Recommend tyriar.sort-lines

* Document global.ts

* Add showOutputView to package.json

* Mark showOutputView todo

* Update ahk2

* Remove showOutputView.onError (wasn't working)

* Add translation

* Update to main

* Update changelog and manual test

* Respect `showOutputView` for debug as well (#70)
@github-project-automation github-project-automation bot moved this from In Progress to Done in AHK++ Sep 20, 2024
@mark-wiemer
Copy link
Member

Ref microsoft/vscode#105270, but I do plan to fix this in the upcoming release. Everything's working now, just trying to add automated tests. They're the first of their kind, so it's taking some time :)

@mark-wiemer mark-wiemer changed the title Disable Output Window Disable Output Window when debugging Sep 22, 2024
@mark-wiemer
Copy link
Member

mark-wiemer commented Sep 22, 2024

OK, further testing shows that even removing any application code to open the debug console view still results on it opening the very first time a debug session begins. Closing the debug console view and debugging again does not reopen the view. Reopening this to see if I can identify the exact issue here, but it'll have to be good enough for a while given the longstanding issues with VS Code itself and the lack of documentation and API support around these features, from what I've been able to find.

My guess right now is that it's related to the initializeRequest or something similar.

@mark-wiemer mark-wiemer reopened this Sep 22, 2024
mark-wiemer added a commit that referenced this issue Sep 22, 2024
@xndyz
Copy link

xndyz commented Sep 23, 2024

Will this prevent the output window from popping up by another conflict in an extension?

@mark-wiemer
Copy link
Member

@andyfangaf no, it shouldn't affect the behavior of other extensions. I'm still researching, but it looks like creating a debug session for the first time is the only case where the output window currently pops up (AHK++ 6.1.1).

I need to rebuild the debugger for advanced use-cases anyway, so I'll be testing a very basic debugger to see if behavior like this is just built-in to VS Code or can be avoided. Stay tuned :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugger issues with debugging code enhancement new feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants