Skip to content

Commit

Permalink
Revert "[Test] Dedup vs2019 test in the Windows test" (grpc#33393)
Browse files Browse the repository at this point in the history
Reverts grpc#33385

Temporary revert to unblock grpc#33138
  • Loading branch information
veblush authored and mario-vimal committed Jun 15, 2023
1 parent 23a8199 commit c6f1950
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 16 deletions.
6 changes: 0 additions & 6 deletions tools/internal_ci/windows/grpc_run_tests_matrix.bat
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ IF "%cd%"=="T:\src" (
)
endlocal

@rem Info on disk usage
dir t:\

@rem enter repo root
cd /d %~dp0\..\..\..

Expand All @@ -51,7 +48,4 @@ set RUNTESTS_EXITCODE=%errorlevel%
@rem show ccache stats
ccache --show-stats

@rem Info on disk usage after test
dir t:\

exit /b %RUNTESTS_EXITCODE%
19 changes: 9 additions & 10 deletions tools/run_tests/run_tests_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,16 +354,15 @@ def _create_portability_test_jobs(extra_args=[],
# TODO(jtattermusch): The C tests with exactly the same config are already running as part of the
# basictests_c suite (so we force --build_only to avoid running them twice).
# The C++ tests aren't all passing, so also force --build_only.
# NOTE(veblush): This is not neded as default=cmake_ninja_vs2019
#test_jobs += _generate_jobs(languages=['c', 'c++'],
# configs=['dbg'],
# platforms=['windows'],
# arch='x64',
# compiler='cmake_ninja_vs2019',
# labels=['portability', 'corelang'],
# extra_args=extra_args + ['--build_only'],
# inner_jobs=inner_jobs,
# timeout_seconds=_CPP_RUNTESTS_TIMEOUT)
test_jobs += _generate_jobs(languages=['c', 'c++'],
configs=['dbg'],
platforms=['windows'],
arch='x64',
compiler='cmake_ninja_vs2019',
labels=['portability', 'corelang'],
extra_args=extra_args + ['--build_only'],
inner_jobs=inner_jobs,
timeout_seconds=_CPP_RUNTESTS_TIMEOUT)

# C and C++ with no-exceptions on Linux
test_jobs += _generate_jobs(languages=['c', 'c++'],
Expand Down

0 comments on commit c6f1950

Please sign in to comment.