Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stitch Prediction in predict_per_example.py #11

Open
jinleyang opened this issue Nov 25, 2024 · 2 comments
Open

Stitch Prediction in predict_per_example.py #11

jinleyang opened this issue Nov 25, 2024 · 2 comments

Comments

@jinleyang
Copy link

jinleyang commented Nov 25, 2024

Hi Maria, thank you for your revolutionary work!

Recently, I encountered an issue in stitch prediction using nn/evaluation_scripts/predict_per_example.py. Actually, there is the exactly same problem in #3 . Specifically, when I use the same testing data (for example, dress_sleeveless_2550/dress_sleeveless_6VN3H6FMOY in seen test split), the stitch results are totally different using predict_per_example.py compared with using nn/evaluation_scripts/on_test_set.py. The one by predict_per_example.py is quite bad (always with one stitch only per garment), but the one by given evaluation script on_test_set.py is quite good (looks correct when visualizing in 3D). By the way, the shape prediction of both script are both good, only stitch is influenced.

My questions are: 1. Since there is no instruction of using predict_per_example.py in official README, I am wondering whether it can be used to infer on single data/folder without GT. 2. What do you think the possible reasons for different stitch prediction?

@maria-korosteleva
Copy link
Owner

Hi @jinleyang

  1. Yes, it's the main purpose of this script, and I would expect it to work 🤔
  2. This is indeed a weird behavior in that the two scripts provide different outputs. I need more context to understand the problem

2.1) Please, share the commands that you run the scripts with, including all the command arguments you supply
2.2) Please, share the outputs (saved files) for the dress_sleeveless_6VN3H6FMOY, from both scripts.

@jinleyang
Copy link
Author

@maria-korosteleva Thank you for your reply!
These are the commands of running each script:
Running on_test_set.py:
python nn/evaluation_scripts/on_test_set.py -sh models/att/att.yaml -st models/att/stitch_model.yaml --predict
Running on predict_per_sample.py:
python nn/evaluation_scripts/predict_per_example.py -sh models/att/att.yaml -st models/att/stitch_model.yaml --file /home/jinleyang/Projects/data/garment/dress_sleeveless_2550/dress_sleeveless_6VN3H6FMOY/dress_sleeveless_6VN3H6FMOY_sim.obj

The checkpoints and configs are the same as the original code. And the output for each script is attached. (For output of on_test_set.py, I only include the folder of dress_sleeveless_6VN3H6FMOY, because the command will generate results for all data in seen test split.)
NeuralTailor_testing.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants