Gnome-circle/a11y #757
Merged
Gnome-circle/a11y #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marhkb
force-pushed
the
gnome-circle/a11y
branch
from
4d0a12d
to
5975c49
Compare
If separators are set explicitly, they can be navigated with the keyboard, which we do not want. Instead, we place a header widget on the listbox row.
After the last commit, we no longer need this widget.
Otherwise, the focus indicator arround the button is a not a circle but a ellipse.
Instead of having an AdwEntryRow wrapped inside an AdwExpanderRow, we now use the entry row directly. This commit also fixes the radio buttons' key activation.
marhkb
force-pushed
the
gnome-circle/a11y
branch
from
883b24a
to
9ba5fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.