-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why are you tracking mousedown? #64
Comments
Hello :) I have no idea today - so I guess it is for historical reasons ;) |
That would be fantastic – I was about to fork and start digging myself. In general I think it would be most useful if this kind of package was a "hooks-only" kind of thing, where the user was responsible for constructing the UI completely on their own. Besides that, at least having the ability to omit desktop environments would make it usable. |
This is pretty old package which I update sometimes with some small fixes. You can check the code that there is old stuff like |
@isaachinman Please check if this is what you need :) #65 |
Yes, I have indeed already had an in-depth look at the source code, and am pondering rewriting it as hooks-only with The PR looks fantastic, thanks for such a rapid fix 👌 |
Hey there. I've been on the hunt for a package like this, and in general think the behaviour you have achieved is fantastic.
However, I was surprised and disappointed to find that the swipe behaviour still activates on desktop/non touch devices. This is totally unexpected – normally this kind of swipe interaction only applies to mobile/touch devices, and should not even be listening for
mousedown
events.I'm sure you had a good reason for doing so, but was also surprised to see that this behaviour is not configurable.
Is there any way to prevent the swipe handlers from listening on desktop/non-touch? Are you aware of any other alternative packages?
Thanks 🙏
The text was updated successfully, but these errors were encountered: