From 25e5a87d2cc8af68fea9a6921ed1e64d41ed2b91 Mon Sep 17 00:00:00 2001 From: Alexey Solovyev <1556417+alex-solovyev@users.noreply.github.com> Date: Wed, 14 Jan 2026 17:35:35 +0000 Subject: [PATCH 1/2] fix: improve secretlint performance by adding ignore patterns - Add python-env, .osgrep, .scannerwork to .secretlintignore - Increase Docker timeout from 30s to 60s - Add t063 task to TODO.md Fixes scanning 19,790 files (572MB) down to ~230 files. Resolves 60+ minute hangs when running linters-local.sh. --- .agent/scripts/linters-local.sh | 6 +++--- .gitignore | 1 + .secretlintignore | 11 +++++++++++ TODO.md | 3 ++- 4 files changed, 17 insertions(+), 4 deletions(-) diff --git a/.agent/scripts/linters-local.sh b/.agent/scripts/linters-local.sh index a21033512..fd2ea7b97 100755 --- a/.agent/scripts/linters-local.sh +++ b/.agent/scripts/linters-local.sh @@ -307,13 +307,13 @@ check_secrets() { print_info "Run: bash $secretlint_script init" fi elif command -v docker &> /dev/null; then - print_info "Secretlint: Using Docker for scan (30s timeout)..." + print_info "Secretlint: Using Docker for scan (60s timeout)..." # Use gtimeout (macOS) or timeout (Linux) to prevent Docker from hanging local timeout_cmd="" if command -v gtimeout &> /dev/null; then - timeout_cmd="gtimeout 30" + timeout_cmd="gtimeout 60" elif command -v timeout &> /dev/null; then - timeout_cmd="timeout 30" + timeout_cmd="timeout 60" fi local docker_result diff --git a/.gitignore b/.gitignore index fb97d4056..a19a0c373 100644 --- a/.gitignore +++ b/.gitignore @@ -90,6 +90,7 @@ node_modules/ package-lock.json pnpm-lock.yaml yarn.lock +bun.lock # OS generated files .DS_Store diff --git a/.secretlintignore b/.secretlintignore index fbb3b1b5d..d58022a6b 100644 --- a/.secretlintignore +++ b/.secretlintignore @@ -105,3 +105,14 @@ # Template files (contain example configurations) **/templates/** + +# Python virtual environments (mirror .gitignore) +**/python-env/** +**/env/** + +# Tool caches and indexes (mirror .gitignore) +**/.osgrep/** +**/.scannerwork/** + +# Lock files +**/bun.lock diff --git a/TODO.md b/TODO.md index 83129d278..35880660e 100644 --- a/TODO.md +++ b/TODO.md @@ -135,6 +135,8 @@ Tasks with no open blockers - ready to work on. Use `/ready` to refresh this lis - Notes: Inspired by opengraphdebug.com. Two subagents: 1) debug-opengraph.md - validate Open Graph meta tags (og:title, og:description, og:image, og:url, twitter:card), preview social sharing appearance, check image dimensions/accessibility. 2) debug-favicon.md - validate favicon setup across platforms (favicon.ico, apple-touch-icon, manifest icons), check sizes/formats, verify PWA manifest. Could use browser automation (Stagehand/Playwright) or direct HTML parsing. Add to tools/seo/ or tools/browser/. - [ ] t062 Research vercel-labs/agent-skills for inclusion in aidevops #research #tools #deployment ~2h (ai:1h read:1h) logged:2026-01-14 ref:https://github.com/vercel-labs/agent-skills - Notes: Vercel's Agent Skills collection (332 stars, MIT). Currently includes vercel-deploy skill for instant deployment without auth. Auto-detects 40+ frameworks, returns preview URL + claim URL. Follows agentskills.io format (SKILL.md structure). Evaluate: 1) Add vercel-deploy as aidevops skill 2) Adopt Agent Skills format for aidevops skills 3) Contribute aidevops skills back to ecosystem. +- [x] t063 Fix secretlint scanning performance #bugfix #secretlint #performance ~30m (ai:15m test:10m read:5m) logged:2026-01-14 completed:2026-01-14 + - Notes: Added python-env, .osgrep, .scannerwork to .secretlintignore. Added bun.lock to .gitignore to maintain subset rule. Increased Docker timeout 30s→60s. Optional: glob whitelist in linters-local.sh for further optimization. From f70b23e3df187604f9404cb102384d56317a38f3 Mon Sep 17 00:00:00 2001 From: marcusquinn <6428977+marcusquinn@users.noreply.github.com> Date: Wed, 14 Jan 2026 19:30:03 +0000 Subject: [PATCH 2/2] fix: address Gemini review feedback - Use variable for secretlint timeout (maintainability) - Fix TODO.md TOON summary: add closing tag, update counts --- .agent/scripts/linters-local.sh | 7 ++++--- TODO.md | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.agent/scripts/linters-local.sh b/.agent/scripts/linters-local.sh index fd2ea7b97..7c6384e11 100755 --- a/.agent/scripts/linters-local.sh +++ b/.agent/scripts/linters-local.sh @@ -307,13 +307,14 @@ check_secrets() { print_info "Run: bash $secretlint_script init" fi elif command -v docker &> /dev/null; then - print_info "Secretlint: Using Docker for scan (60s timeout)..." + local secretlint_timeout=60 + print_info "Secretlint: Using Docker for scan (${secretlint_timeout}s timeout)..." # Use gtimeout (macOS) or timeout (Linux) to prevent Docker from hanging local timeout_cmd="" if command -v gtimeout &> /dev/null; then - timeout_cmd="gtimeout 60" + timeout_cmd="gtimeout ${secretlint_timeout}" elif command -v timeout &> /dev/null; then - timeout_cmd="timeout 60" + timeout_cmd="timeout ${secretlint_timeout}" fi local docker_result diff --git a/TODO.md b/TODO.md index 35880660e..26831822c 100644 --- a/TODO.md +++ b/TODO.md @@ -280,4 +280,5 @@ t019.3.4,Update AGENTS.md with Beads integration docs,,beads,1h,45m,2025-12-21T1 -->