From fa588697f4cd74846a738f4d143ae98b101fe483 Mon Sep 17 00:00:00 2001
From: marcusquinn <6428977+marcusquinn@users.noreply.github.com>
Date: Sun, 11 Jan 2026 03:22:03 +0000
Subject: [PATCH] fix(sonarcloud): add missing default cases to case statements

Fixes S131 violations:
- quality-loop-helper.sh: Add default case for unknown PR status
- terminal-title-helper.sh: Add default cases for terminal detection

These were the 3 critical SonarCloud issues reported in postflight.
---
 .agent/scripts/quality-loop-helper.sh   | 3 +++
 .agent/scripts/terminal-title-helper.sh | 6 ++++++
 2 files changed, 9 insertions(+)

diff --git a/.agent/scripts/quality-loop-helper.sh b/.agent/scripts/quality-loop-helper.sh
index 103eec49f..191467723 100755
--- a/.agent/scripts/quality-loop-helper.sh
+++ b/.agent/scripts/quality-loop-helper.sh
@@ -816,6 +816,9 @@ pr_review_loop() {
                     fi
                 fi
                 ;;
+            *)
+                print_warning "Unknown PR status: $status"
+                ;;
         esac
         
         iteration=$(increment_iteration)
diff --git a/.agent/scripts/terminal-title-helper.sh b/.agent/scripts/terminal-title-helper.sh
index d453b675c..a64aa5abc 100755
--- a/.agent/scripts/terminal-title-helper.sh
+++ b/.agent/scripts/terminal-title-helper.sh
@@ -99,6 +99,9 @@ detect_terminal() {
             echo "hyper"
             return 0
             ;;
+        *)
+            # Not a known TERM_PROGRAM, continue to TERM check
+            ;;
     esac
     
     # Check by TERM variable for other terminals
@@ -107,6 +110,9 @@ detect_terminal() {
             echo "compatible"
             return 0
             ;;
+        *)
+            # Not a known TERM, continue to other checks
+            ;;
     esac
     
     # Check for Windows Terminal