From a17ad383413dd64c322f0b728757cd579afeb243 Mon Sep 17 00:00:00 2001 From: marcusquinn <6428977+marcusquinn@users.noreply.github.com> Date: Mon, 9 Mar 2026 22:59:16 +0000 Subject: [PATCH] fix: address PR #4020 review bot suggestions - Simplify JSON array check to single glob match (Gemini suggestion) - Remove redundant slug_safe redefinition (CodeRabbit nitpick) --- .agents/scripts/contributor-activity-helper.sh | 2 +- .agents/scripts/pulse-wrapper.sh | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.agents/scripts/contributor-activity-helper.sh b/.agents/scripts/contributor-activity-helper.sh index 97ac834f47..1091514afe 100755 --- a/.agents/scripts/contributor-activity-helper.sh +++ b/.agents/scripts/contributor-activity-helper.sh @@ -633,7 +633,7 @@ else: ") || query_result="[]" # t1427: sqlite3 -json returns "" (not "[]") when no rows match. - if [[ -z "$query_result" || "${query_result:0:1}" != "[" ]]; then + if [[ "$query_result" != "["* ]]; then query_result="[]" fi diff --git a/.agents/scripts/pulse-wrapper.sh b/.agents/scripts/pulse-wrapper.sh index 64ea5c9ce1..cd658a77b8 100755 --- a/.agents/scripts/pulse-wrapper.sh +++ b/.agents/scripts/pulse-wrapper.sh @@ -1962,7 +1962,6 @@ ${worker_table}" session_time_md="_Activity helper not installed._" fi # t1426: person-stats from hourly cache (see _refresh_person_stats_cache) - local slug_safe="${repo_slug//\//-}" local ps_cache="${PERSON_STATS_CACHE_DIR}/person-stats-cache-${slug_safe}.md" if [[ -f "$ps_cache" ]]; then person_stats_md=$(cat "$ps_cache")