From e540ad0b6d3475bcd0fb0742b05c3dd329a8743d Mon Sep 17 00:00:00 2001
From: marcusquinn <6428977+marcusquinn@users.noreply.github.com>
Date: Sun, 11 Jan 2026 01:15:51 +0000
Subject: [PATCH 1/2] fix: resolve postflight ShellCheck and return statement
 issues

- Remove erroneous 'return 0' after main in 3 scripts (fix-s131-default-cases, generate-skills, gsc-add-user-helper)
- Add missing 'return 0' in main() for 3 scripts (ralph-upstream-check, terminal-title-setup, todo-ready)
- Remove unused HELPER_SCRIPT variable (SC2034) in terminal-title-setup.sh
- Replace 'ls -la' with 'find -exec ls -ld' (SC2012) in dev-browser-helper.sh
---
 .agent/scripts/dev-browser-helper.sh     | 2 +-
 .agent/scripts/fix-s131-default-cases.sh | 2 --
 .agent/scripts/generate-skills.sh        | 2 --
 .agent/scripts/gsc-add-user-helper.sh    | 2 --
 .agent/scripts/ralph-upstream-check.sh   | 2 ++
 .agent/scripts/terminal-title-setup.sh   | 5 ++---
 .agent/scripts/todo-ready.sh             | 2 ++
 7 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/.agent/scripts/dev-browser-helper.sh b/.agent/scripts/dev-browser-helper.sh
index ec8dbb24a..6a1a11872 100755
--- a/.agent/scripts/dev-browser-helper.sh
+++ b/.agent/scripts/dev-browser-helper.sh
@@ -329,7 +329,7 @@ show_profile() {
         print_success "Profile exists (${profile_size})"
         echo ""
         print_info "Contents:"
-        ls -la "${PROFILE_DIR}" 2>/dev/null | head -20
+        find "${PROFILE_DIR}" -maxdepth 1 -exec ls -ld {} \; 2>/dev/null | head -20
         echo ""
         print_info "This profile persists:"
         print_info "  - Cookies (stay logged into sites)"
diff --git a/.agent/scripts/fix-s131-default-cases.sh b/.agent/scripts/fix-s131-default-cases.sh
index be3affb9f..29de4e345 100755
--- a/.agent/scripts/fix-s131-default-cases.sh
+++ b/.agent/scripts/fix-s131-default-cases.sh
@@ -245,5 +245,3 @@ main() {
 }
 
 main "$@"
-
-return 0
diff --git a/.agent/scripts/generate-skills.sh b/.agent/scripts/generate-skills.sh
index 2c071820e..ef585221c 100755
--- a/.agent/scripts/generate-skills.sh
+++ b/.agent/scripts/generate-skills.sh
@@ -352,5 +352,3 @@ if [[ "$DRY_RUN" == true ]]; then
     log_warning ""
     log_warning "This was a dry run. Run without --dry-run to generate files."
 fi
-
-return 0
diff --git a/.agent/scripts/gsc-add-user-helper.sh b/.agent/scripts/gsc-add-user-helper.sh
index 3c2cb6a70..7d770a195 100755
--- a/.agent/scripts/gsc-add-user-helper.sh
+++ b/.agent/scripts/gsc-add-user-helper.sh
@@ -311,5 +311,3 @@ case "${1:-}" in
         exit 1
         ;;
 esac
-
-return 0
diff --git a/.agent/scripts/ralph-upstream-check.sh b/.agent/scripts/ralph-upstream-check.sh
index 35ccb61e4..b65c35dcb 100755
--- a/.agent/scripts/ralph-upstream-check.sh
+++ b/.agent/scripts/ralph-upstream-check.sh
@@ -320,6 +320,8 @@ main() {
     fi
     
     check_upstream
+    
+    return 0
 }
 
 main "$@"
diff --git a/.agent/scripts/terminal-title-setup.sh b/.agent/scripts/terminal-title-setup.sh
index 54735d1c8..e2a6bb19f 100755
--- a/.agent/scripts/terminal-title-setup.sh
+++ b/.agent/scripts/terminal-title-setup.sh
@@ -33,9 +33,6 @@ log_error() { echo -e "${RED}[ERROR]${NC} $*" >&2; }
 MARKER_START="# >>> aidevops terminal-title integration >>>"
 MARKER_END="# <<< aidevops terminal-title integration <<<"
 
-# Helper script path
-HELPER_SCRIPT="$HOME/.aidevops/agents/scripts/terminal-title-helper.sh"
-
 # =============================================================================
 # Shell Detection
 # =============================================================================
@@ -529,6 +526,8 @@ main() {
             return 1
             ;;
     esac
+    
+    return 0
 }
 
 main "$@"
diff --git a/.agent/scripts/todo-ready.sh b/.agent/scripts/todo-ready.sh
index 3e75e1538..dde0b6a84 100755
--- a/.agent/scripts/todo-ready.sh
+++ b/.agent/scripts/todo-ready.sh
@@ -251,6 +251,8 @@ main() {
             parse_tasks "$todo_file" | output_text
             ;;
     esac
+    
+    return 0
 }
 
 main "$@"

From c9838c5d136e6e7251c69a71828173f8ecbd2697 Mon Sep 17 00:00:00 2001
From: marcusquinn <6428977+marcusquinn@users.noreply.github.com>
Date: Sun, 11 Jan 2026 01:46:02 +0000
Subject: [PATCH 2/2] fix: address review feedback from Gemini and Augment

- dev-browser-helper.sh: Use subshell cd + find for cleaner output format
- terminal-title-setup.sh: Remove explicit return 0 to propagate command status
---
 .agent/scripts/dev-browser-helper.sh   | 2 +-
 .agent/scripts/terminal-title-setup.sh | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/.agent/scripts/dev-browser-helper.sh b/.agent/scripts/dev-browser-helper.sh
index 6a1a11872..aa19a539c 100755
--- a/.agent/scripts/dev-browser-helper.sh
+++ b/.agent/scripts/dev-browser-helper.sh
@@ -329,7 +329,7 @@ show_profile() {
         print_success "Profile exists (${profile_size})"
         echo ""
         print_info "Contents:"
-        find "${PROFILE_DIR}" -maxdepth 1 -exec ls -ld {} \; 2>/dev/null | head -20
+        (cd "${PROFILE_DIR}" && find . -maxdepth 1 -mindepth 1 -exec ls -ld {} +) 2>/dev/null | head -20
         echo ""
         print_info "This profile persists:"
         print_info "  - Cookies (stay logged into sites)"
diff --git a/.agent/scripts/terminal-title-setup.sh b/.agent/scripts/terminal-title-setup.sh
index e2a6bb19f..33f26a276 100755
--- a/.agent/scripts/terminal-title-setup.sh
+++ b/.agent/scripts/terminal-title-setup.sh
@@ -526,8 +526,7 @@ main() {
             return 1
             ;;
     esac
-    
-    return 0
+    # Return status of the executed command
 }
 
 main "$@"