From 2b9ce7fa734018990b6d08cb2cac4324175a5b58 Mon Sep 17 00:00:00 2001
From: marcusquinn <6428977+marcusquinn@users.noreply.github.com>
Date: Tue, 3 Feb 2026 01:57:58 +0000
Subject: [PATCH 1/2] docs: add security follow-up tasks and plans

---
 TODO.md       |  5 +++
 todo/PLANS.md | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 100 insertions(+), 1 deletion(-)

diff --git a/TODO.md b/TODO.md
index 20cbf6b27..bdbf9135f 100644
--- a/TODO.md
+++ b/TODO.md
@@ -52,6 +52,11 @@ Tasks with no open blockers - ready to work on. Use `/ready` to refresh this lis
 
 ## Backlog
 
+- [ ] t104 Install script integrity hardening (replace curl|sh with verified downloads) #security #supply-chain #plan → [todo/PLANS.md#2026-02-03-install-script-integrity-hardening] ~4h (ai:2h test:1h read:1h) logged:2026-02-03
+- [ ] t105 Remove eval in ampcode-cli.sh (use arrays + whitelist formats) #security #shell ~1h (ai:45m test:15m) logged:2026-02-03
+- [ ] t106 Replace eval in system-cleanup.sh find command construction with safe args #security #shell ~1h (ai:45m test:15m) logged:2026-02-03
+- [ ] t107 Avoid eval-based export in credential-helper.sh; use safe output/quoting #security #shell ~1h (ai:45m test:15m) logged:2026-02-03
+- [ ] t108 Dashboard token storage hardening (avoid localStorage; add reset/clear flow) #security #dashboard #plan → [todo/PLANS.md#2026-02-03-dashboard-token-storage-hardening] ~3h (ai:1.5h test:1h read:30m) logged:2026-02-03
 - [ ] t082 Fix version sync inconsistency (VERSION vs package.json/setup.sh/aidevops.sh) #bugfix ~15m (ai:10m test:5m) logged:2026-01-29
   - Notes: Release commit bd0695c bumped VERSION to 2.92.1 but missed syncing package.json, setup.sh, aidevops.sh, sonar-project.properties, .claude-plugin/marketplace.json. Either fix manually or ensure version-manager.sh is used for all releases.
 - [ ] t068 Multi-Agent Orchestration & Token Efficiency #plan → [todo/PLANS.md#2026-01-23-multi-agent-orchestration--token-efficiency] ~5d (ai:3d test:1d read:1d) logged:2026-01-23 started:2026-01-23T00:00Z
diff --git a/todo/PLANS.md b/todo/PLANS.md
index 6bf00dd46..4a55e94f7 100644
--- a/todo/PLANS.md
+++ b/todo/PLANS.md
@@ -21,6 +21,98 @@ Each plan includes:
 
 ## Active Plans
 
+### [2026-02-03] Install Script Integrity Hardening
+
+**Status:** Planning
+**Estimate:** ~4h (ai:2h test:1h read:1h)
+
+<!--TOON:plan{id,title,status,phase,total_phases,owner,tags,est,est_ai,est_test,est_read,logged,started}:
+p013,Install Script Integrity Hardening,planning,0,4,,security|supply-chain|setup,4h,2h,1h,1h,2026-02-03T00:00Z,
+-->
+
+#### Purpose
+
+Eliminate `curl | sh` installs by downloading scripts to disk, verifying integrity (checksum or signature), and executing locally. This reduces supply-chain exposure in setup and helper scripts.
+
+#### Context from Discussion
+
+Targets include:
+- `setup.sh` (multiple install blocks)
+- `.agent/scripts/qlty-cli.sh`
+- `.agent/scripts/coderabbit-cli.sh`
+- `.agent/scripts/dev-browser-helper.sh`
+
+#### Progress
+
+- [ ] (2026-02-03) Phase 1: Inventory all `curl|sh` usages and vendor verification options ~45m
+- [ ] (2026-02-03) Phase 2: Replace with download → verify → execute flow ~2h
+- [ ] (2026-02-03) Phase 3: Add fallback behavior and clear error messages ~45m
+- [ ] (2026-02-03) Phase 4: Update docs/tests and verify behavior ~30m
+
+<!--TOON:milestones[4]{id,plan_id,desc,est,actual,scheduled,completed,status}:
+m064,p013,Phase 1: Inventory curl|sh usages and verification options,45m,,2026-02-03T00:00Z,,pending
+m065,p013,Phase 2: Replace with download-verify-execute flow,2h,,2026-02-03T00:00Z,,pending
+m066,p013,Phase 3: Add fallback behavior and error messages,45m,,2026-02-03T00:00Z,,pending
+m067,p013,Phase 4: Update docs/tests and verify behavior,30m,,2026-02-03T00:00Z,,pending
+-->
+
+#### Decision Log
+
+(To be populated during implementation)
+
+<!--TOON:decisions[0]{id,plan_id,decision,rationale,date,impact}:
+-->
+
+#### Surprises & Discoveries
+
+(To be populated during implementation)
+
+<!--TOON:discoveries[0]{id,plan_id,observation,evidence,impact,date}:
+-->
+
+### [2026-02-03] Dashboard Token Storage Hardening
+
+**Status:** Planning
+**Estimate:** ~3h (ai:1.5h test:1h read:30m)
+
+<!--TOON:plan{id,title,status,phase,total_phases,owner,tags,est,est_ai,est_test,est_read,logged,started}:
+p014,Dashboard Token Storage Hardening,planning,0,3,,security|auth|dashboard,3h,1.5h,1h,30m,2026-02-03T00:00Z,
+-->
+
+#### Purpose
+
+Replace persistent `localStorage` token usage with session/memory-based storage and add a clear/reset flow to reduce XSS exposure and leaked tokens on shared machines.
+
+#### Context from Discussion
+
+Current usage persists `dashboardToken` in `localStorage` in the MCP dashboard UI. Update to session-scoped storage and ensure logout/reset clears state.
+
+#### Progress
+
+- [ ] (2026-02-03) Phase 1: Trace token flow and identify all storage/read paths ~45m
+- [ ] (2026-02-03) Phase 2: Migrate to session/memory storage and update auth flow ~1.5h
+- [ ] (2026-02-03) Phase 3: Add reset/clear UI flow and verify behavior ~45m
+
+<!--TOON:milestones[3]{id,plan_id,desc,est,actual,scheduled,completed,status}:
+m068,p014,Phase 1: Trace token flow and storage paths,45m,,2026-02-03T00:00Z,,pending
+m069,p014,Phase 2: Migrate to session/memory storage and update auth flow,1.5h,,2026-02-03T00:00Z,,pending
+m070,p014,Phase 3: Add reset/clear UI flow and verify behavior,45m,,2026-02-03T00:00Z,,pending
+-->
+
+#### Decision Log
+
+(To be populated during implementation)
+
+<!--TOON:decisions[0]{id,plan_id,decision,rationale,date,impact}:
+-->
+
+#### Surprises & Discoveries
+
+(To be populated during implementation)
+
+<!--TOON:discoveries[0]{id,plan_id,observation,evidence,impact,date}:
+-->
+
 ### [2025-12-21] aidevops-opencode Plugin
 
 **Status:** Planning
@@ -800,7 +892,9 @@ disc001,p009,Implementation faster than estimated,All core functionality already
 p009,beads-sync-helper.sh; todo-ready.sh; beads.md subagent; blocked-by/blocks syntax; hierarchical IDs; TOON schema; setup.sh integration; AGENTS.md docs,Robust sync script; comprehensive docs; seamless integration,Add optional UI installation to setup.sh,2d,1.5d,-25,1
 -->
 
-<!--TOON:active_plans[9]{id,title,status,phase,total_phases,owner,tags,est,est_ai,est_test,est_read,logged,started}:
+<!--TOON:active_plans[11]{id,title,status,phase,total_phases,owner,tags,est,est_ai,est_test,est_read,logged,started}:
+p013,Install Script Integrity Hardening,planning,0,4,,security|supply-chain|setup,4h,2h,1h,1h,2026-02-03T00:00Z,
+p014,Dashboard Token Storage Hardening,planning,0,3,,security|auth|dashboard,3h,1.5h,1h,30m,2026-02-03T00:00Z,
 p001,aidevops-opencode Plugin,planning,0,4,,opencode|plugin,2d,1d,0.5d,0.5d,2025-12-21T01:50Z,
 p002,Claude Code Destructive Command Hooks,planning,0,4,,claude|git|security,4h,2h,1h,1h,2025-12-21T12:00Z,
 p003,Evaluate Merging build-agent and build-mcp into aidevops,planning,0,3,,architecture|agents,4h,2h,1h,1h,2025-12-21T14:00Z,

From 4e84bc17ab086b5dfb0903fe73c91e42d21a5050 Mon Sep 17 00:00:00 2001
From: marcusquinn <6428977+marcusquinn@users.noreply.github.com>
Date: Tue, 3 Feb 2026 02:22:48 +0000
Subject: [PATCH 2/2] fix: align TOON metadata and auto-advance full loop

---
 .agent/scripts/full-loop-helper.sh |  9 +++++++++
 TODO.md                            |  7 ++++++-
 todo/PLANS.md                      | 24 ++++++++++++------------
 3 files changed, 27 insertions(+), 13 deletions(-)

diff --git a/.agent/scripts/full-loop-helper.sh b/.agent/scripts/full-loop-helper.sh
index d1ddfa64c..a4e00e07e 100755
--- a/.agent/scripts/full-loop-helper.sh
+++ b/.agent/scripts/full-loop-helper.sh
@@ -603,6 +603,15 @@ cmd_start() {
 cmd_run_foreground() {
     local prompt="$1"
     run_task_phase "$prompt"
+
+    # Auto-advance when task phase completes in v2.
+    # Legacy mode leaves a Ralph state file; in that case we must wait for manual completion.
+    if [[ -f ".agent/loop-state/ralph-loop.local.state" ]] || [[ -f ".claude/ralph-loop.local.state" ]]; then
+        print_warning "Task loop still active (legacy mode). Run: full-loop-helper.sh resume when complete."
+        return 0
+    fi
+
+    cmd_resume
     return 0
 }
 
diff --git a/TODO.md b/TODO.md
index bdbf9135f..1c44b7e8b 100644
--- a/TODO.md
+++ b/TODO.md
@@ -247,7 +247,12 @@ Tasks with no open blockers - ready to work on. Use `/ready` to refresh this lis
 - [x] t067 Optimise OpenCode MCP loading with on-demand activation #opencode #performance #mcp ~4h (ai:2h test:1h read:1h) logged:2026-01-21 blocked-by:t056 started:2026-01-21T06:15Z completed:2026-01-21 actual:30m
   - Notes: Implemented on-demand MCP loading pattern. Updated generate-opencode-agents.sh to sync MCP index on agent generation. Added MCP On-Demand Loading section to AGENTS.md. Pattern: MCPs disabled globally, enabled per-subagent via frontmatter, discoverable via mcp-index-helper.sh search.
 
-<!--TOON:backlog[52]{id,desc,owner,tags,est,est_ai,est_test,logged,status,blocked_by,blocks,parent}:
+<!--TOON:backlog[57]{id,desc,owner,tags,est,est_ai,est_test,logged,status,blocked_by,blocks,parent}:
+t104,Install script integrity hardening (replace curl|sh with verified downloads),,security|supply-chain|plan,4h,2h,1h,2026-02-03T00:00Z,pending,,,
+t105,Remove eval in ampcode-cli.sh (use arrays + whitelist formats),,security|shell,1h,45m,15m,2026-02-03T00:00Z,pending,,,
+t106,Replace eval in system-cleanup.sh find command construction with safe args,,security|shell,1h,45m,15m,2026-02-03T00:00Z,pending,,,
+t107,Avoid eval-based export in credential-helper.sh; use safe output/quoting,,security|shell,1h,45m,15m,2026-02-03T00:00Z,pending,,,
+t108,Dashboard token storage hardening (avoid localStorage; add reset/clear flow),,security|dashboard|plan,3h,1.5h,1h,2026-02-03T00:00Z,pending,,,
 t073,Document Extraction Subagent & Workflow,,plan|document-extraction|docling|extractthinker|presidio|pii|local-llm|privacy,3h,1h,2h,2026-01-25T01:00Z,pending,,,
 t073.1,Implementation (all subagents + scripts),,document-extraction,1h,1h,,2026-01-25T01:00Z,pending,,,t073
 t073.2,Integration Testing,,document-extraction|testing,2h,,2h,2026-01-25T01:00Z,pending,t073.1,,t073
diff --git a/todo/PLANS.md b/todo/PLANS.md
index 4a55e94f7..1131b692e 100644
--- a/todo/PLANS.md
+++ b/todo/PLANS.md
@@ -27,7 +27,7 @@ Each plan includes:
 **Estimate:** ~4h (ai:2h test:1h read:1h)
 
 <!--TOON:plan{id,title,status,phase,total_phases,owner,tags,est,est_ai,est_test,est_read,logged,started}:
-p013,Install Script Integrity Hardening,planning,0,4,,security|supply-chain|setup,4h,2h,1h,1h,2026-02-03T00:00Z,
+p016,Install Script Integrity Hardening,planning,0,4,,security|supply-chain|setup,4h,2h,1h,1h,2026-02-03T00:00Z,
 -->
 
 #### Purpose
@@ -50,10 +50,10 @@ Targets include:
 - [ ] (2026-02-03) Phase 4: Update docs/tests and verify behavior ~30m
 
 <!--TOON:milestones[4]{id,plan_id,desc,est,actual,scheduled,completed,status}:
-m064,p013,Phase 1: Inventory curl|sh usages and verification options,45m,,2026-02-03T00:00Z,,pending
-m065,p013,Phase 2: Replace with download-verify-execute flow,2h,,2026-02-03T00:00Z,,pending
-m066,p013,Phase 3: Add fallback behavior and error messages,45m,,2026-02-03T00:00Z,,pending
-m067,p013,Phase 4: Update docs/tests and verify behavior,30m,,2026-02-03T00:00Z,,pending
+m064,p016,Phase 1: Inventory curl|sh usages and verification options,45m,,2026-02-03T00:00Z,,pending
+m065,p016,Phase 2: Replace with download-verify-execute flow,2h,,2026-02-03T00:00Z,,pending
+m066,p016,Phase 3: Add fallback behavior and error messages,45m,,2026-02-03T00:00Z,,pending
+m067,p016,Phase 4: Update docs/tests and verify behavior,30m,,2026-02-03T00:00Z,,pending
 -->
 
 #### Decision Log
@@ -76,7 +76,7 @@ m067,p013,Phase 4: Update docs/tests and verify behavior,30m,,2026-02-03T00:00Z,
 **Estimate:** ~3h (ai:1.5h test:1h read:30m)
 
 <!--TOON:plan{id,title,status,phase,total_phases,owner,tags,est,est_ai,est_test,est_read,logged,started}:
-p014,Dashboard Token Storage Hardening,planning,0,3,,security|auth|dashboard,3h,1.5h,1h,30m,2026-02-03T00:00Z,
+p017,Dashboard Token Storage Hardening,planning,0,3,,security|auth|dashboard,3h,1.5h,1h,30m,2026-02-03T00:00Z,
 -->
 
 #### Purpose
@@ -94,9 +94,9 @@ Current usage persists `dashboardToken` in `localStorage` in the MCP dashboard U
 - [ ] (2026-02-03) Phase 3: Add reset/clear UI flow and verify behavior ~45m
 
 <!--TOON:milestones[3]{id,plan_id,desc,est,actual,scheduled,completed,status}:
-m068,p014,Phase 1: Trace token flow and storage paths,45m,,2026-02-03T00:00Z,,pending
-m069,p014,Phase 2: Migrate to session/memory storage and update auth flow,1.5h,,2026-02-03T00:00Z,,pending
-m070,p014,Phase 3: Add reset/clear UI flow and verify behavior,45m,,2026-02-03T00:00Z,,pending
+m068,p017,Phase 1: Trace token flow and storage paths,45m,,2026-02-03T00:00Z,,pending
+m069,p017,Phase 2: Migrate to session/memory storage and update auth flow,1.5h,,2026-02-03T00:00Z,,pending
+m070,p017,Phase 3: Add reset/clear UI flow and verify behavior,45m,,2026-02-03T00:00Z,,pending
 -->
 
 #### Decision Log
@@ -892,9 +892,9 @@ disc001,p009,Implementation faster than estimated,All core functionality already
 p009,beads-sync-helper.sh; todo-ready.sh; beads.md subagent; blocked-by/blocks syntax; hierarchical IDs; TOON schema; setup.sh integration; AGENTS.md docs,Robust sync script; comprehensive docs; seamless integration,Add optional UI installation to setup.sh,2d,1.5d,-25,1
 -->
 
-<!--TOON:active_plans[11]{id,title,status,phase,total_phases,owner,tags,est,est_ai,est_test,est_read,logged,started}:
-p013,Install Script Integrity Hardening,planning,0,4,,security|supply-chain|setup,4h,2h,1h,1h,2026-02-03T00:00Z,
-p014,Dashboard Token Storage Hardening,planning,0,3,,security|auth|dashboard,3h,1.5h,1h,30m,2026-02-03T00:00Z,
+<!--TOON:active_plans[12]{id,title,status,phase,total_phases,owner,tags,est,est_ai,est_test,est_read,logged,started}:
+p016,Install Script Integrity Hardening,planning,0,4,,security|supply-chain|setup,4h,2h,1h,1h,2026-02-03T00:00Z,
+p017,Dashboard Token Storage Hardening,planning,0,3,,security|auth|dashboard,3h,1.5h,1h,30m,2026-02-03T00:00Z,
 p001,aidevops-opencode Plugin,planning,0,4,,opencode|plugin,2d,1d,0.5d,0.5d,2025-12-21T01:50Z,
 p002,Claude Code Destructive Command Hooks,planning,0,4,,claude|git|security,4h,2h,1h,1h,2025-12-21T12:00Z,
 p003,Evaluate Merging build-agent and build-mcp into aidevops,planning,0,3,,architecture|agents,4h,2h,1h,1h,2025-12-21T14:00Z,