Skip to content

Conversation

@eps1lon
Copy link

@eps1lon eps1lon commented Dec 11, 2020

  • revert most runtime changes
  • test over exec because semantics
  • explain eslint-disables
  • remove extensions

Targeted at testing-library#848

- revert most runtime changes
- test over exec because semantics
@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (pr/pr_typescript_migration@03f20e1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                      Coverage Diff                       @@
##             pr/pr_typescript_migration        #2   +/-   ##
==============================================================
  Coverage                              ?   100.00%           
==============================================================
  Files                                 ?        26           
  Lines                                 ?       938           
  Branches                              ?       287           
==============================================================
  Hits                                  ?       938           
  Misses                                ?         0           
  Partials                              ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f20e1...6c08f92. Read the comment docs.

@marcosvega91
Copy link
Owner

thanks :). Is it ready ? looks good

@eps1lon
Copy link
Author

eps1lon commented Dec 11, 2020

Leaving this for visibility. Cherry-picking them directly into the PR. But for a release I want to make sure we're not changing runtime behavior needlessly.

@eps1lon eps1lon closed this Dec 11, 2020
@eps1lon eps1lon deleted the types-polish branch December 11, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants