Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make call to set_attributes to match the OTLP specs #114

Closed
leggebroten opened this issue Jun 29, 2023 · 1 comment
Closed

Make call to set_attributes to match the OTLP specs #114

leggebroten opened this issue Jun 29, 2023 · 1 comment

Comments

@leggebroten
Copy link
Contributor

Currently, the result of Attributes.get_attributes returns a Keyword which is then passed directly to Tracer.set_attributes.

This is not consistent with the spec which expects a list of two element tuples, {attribute_name_as_binary, OTLP_acceptable_value}

Where a OTLP_acceptable_value is: string, integer, double or boolean

This could lead to integration issues with certain providers.

Example

[{"/http/user_agent" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36"}
 {"/http/server_latency", 300}
 {"abc.com/myattribute", True}
 {"abc.com/score", 10.239}]
@marcdel
Copy link
Owner

marcdel commented Jul 7, 2023

Good catch! Fixed in 2f5ac96

@marcdel marcdel closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants