Bump golangci/golangci-lint from v1.47.3 to v1.48.0 (#20)

* Bump golangci/golangci-lint from v1.47.3 to v1.48.0

Bumps golangci/golangci-lint from v1.47.3 to v1.48.0.

---
updated-dependencies:
- dependency-name: golangci/golangci-lint
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update ci and config

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Marat Reymers <[email protected]>

Author: dependabot[bot]

.github/workflows/ci.yml

@@ -41,7 +41,7 @@ jobs:
           go-version: "1.x"
       - uses: golangci/golangci-lint-action@v3
         with:
-          version: "v1.47.2" # update together with Dockerfile.dev
+          version: "v1.48.0" # update together with Dockerfile.dev
 
   check-tidy:
     name: go mod tidy

.golangci.yml

@@ -205,6 +205,7 @@ linters:
     - tparallel # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes
     - unconvert # Remove unnecessary type conversions
     - unparam # Reports unused function parameters
+    - usestdlibvars # detect the possibility to use variables/constants from the Go standard library
     - wastedassign # wastedassign finds wasted assignment statements.
     - whitespace # Tool for detection of leading and trailing whitespace
     ## you may want to enable
@@ -227,7 +228,6 @@ linters:
     #- gofmt # [replaced by goimports] Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification
     #- gofumpt # [replaced by goimports, gofumports is not available yet] Gofumpt checks whether code was gofumpt-ed.
     #- grouper # An analyzer to analyze expression groups.
-    #- ifshort # Checks that your code uses short syntax for if-statements whenever possible
     #- importas # Enforces consistent import aliases
     #- maintidx # maintidx measures the maintainability index of each function.
     #- misspell # [useless] Finds commonly misspelled English words in comments
@@ -240,6 +240,7 @@ linters:
     ## deprecated
     #- exhaustivestruct # [deprecated, replaced by exhaustruct] Checks if all struct's fields are initialized
     #- golint # [deprecated, replaced by revive] Golint differs from gofmt. Gofmt reformats Go source code, whereas golint prints out style mistakes
+    #- ifshort # [deprecated, by the owner] Checks that your code uses short syntax for if-statements whenever possible
     #- interfacer # [deprecated] Linter that suggests narrower interface types
     #- maligned # [deprecated, replaced by govet fieldalignment] Tool to detect Go structs that would take less memory if their fields were sorted
     #- scopelint # [deprecated, replaced by exportloopref] Scopelint checks for unpinned variables in go programs

Dockerfile.dev

@@ -1,7 +1,7 @@
 FROM golang:1.18.5 AS go
 
 # update together with .github/workflows/ci.yml
-FROM golangci/golangci-lint:v1.47.3 AS linter
+FROM golangci/golangci-lint:v1.48.0 AS linter
 
 FROM go AS dev
 ENV INSIDE_DEV_CONTAINER 1

async.go

@@ -47,7 +47,7 @@ func NewExecutor() *Executor {
 //
 // You can't register the same jobName twice.
 // You can't register the same method twice.
-func (e *Executor) Register( // nolint:gocognit // TODO: simplify
+func (e *Executor) Register( //nolint:gocognit // TODO: simplify
 	jobName string,
 	receiver interface{},
 	method interface{},
@@ -98,7 +98,7 @@ func (e *Executor) Register( // nolint:gocognit // TODO: simplify
 				return errors.Errorf("args[%d]: wrong type: %s expected, received %s", i, expectedType, actualType)
 			}
 
-			args = append(args, marshalStruct.Field(i*2)) // nolint:gomnd // even numbers
+			args = append(args, marshalStruct.Field(i*2)) //nolint:gomnd // even numbers
 		}
 
 		res := methodVal.Call(args)
@@ -151,7 +151,7 @@ func (e *Executor) Prepare(method interface{}, args ...interface{}) (string, jso
 			return "", nil, errors.Errorf("args[%d]: expected %s, received %s", i, eType, aType)
 		}
 
-		marshalStruct.Field(i * 2).Set(reflect.ValueOf(args[i])) // nolint:gomnd // even numbers
+		marshalStruct.Field(i * 2).Set(reflect.ValueOf(args[i])) //nolint:gomnd // even numbers
 		marshalStruct.Field(1 + i*2).SetString(info.paramTypes[i])
 	}
 
@@ -192,7 +192,7 @@ func (e *Executor) validateAndGetMethodInfo(
 
 	receivesContext := false
 	returnsError := false
-	marshalFields := make([]reflect.StructField, 0, 2*method.NumIn()) // nolint:gomnd // param encoded with 2 fields
+	marshalFields := make([]reflect.StructField, 0, 2*method.NumIn()) //nolint:gomnd // param encoded with 2 fields
 	paramTypes := make([]string, 0, method.NumIn())
 	offset := 1
 

async_test.go

@@ -49,7 +49,7 @@ func TestExecutor(t *testing.T) {
 			domainService := NewDomainService()
 			handler1, err := executor.Register("job1", domainService, DomainService.Struct__String__Nothing)
 			require.NoError(t, err)
-			handler2, err := executor.Register("job2", domainService, DomainService.OneMoreMethodSameSignature_Struct__String__Nothing) // nolint:lll
+			handler2, err := executor.Register("job2", domainService, DomainService.OneMoreMethodSameSignature_Struct__String__Nothing) //nolint:lll
 			require.NoError(t, err)
 			name1, data1, err := executor.Prepare(DomainService.Struct__String__Nothing, arg)
 			require.NoError(t, err)