Add 0:0 special cardinality value.
#480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new cardinality value of `0:0`, to be used for mapping records where both the `subject_id` and the `object_id` are sssom:NoTermFound. Such records are allowed and may be used to represent the fact that there is no overlap between a subject vocabulary and an object vocabulary. We also try to explain a bit more what the different cardinality values mean exactly, and provide two examples: * one that illustrates all possible cardinality values between real mappings (1:1, 1:n, n:1, n:n); * one that illustrates the special cases where the subject_id and/or the object_id is sssom:NoTermFound. closes #477
gouttegd
force-pushed
the
cardinality-for-unmapped-entities
branch
from
977dbfc to
909d2af
Compare
matentzn
reviewed
Aug 12, 2025
Collaborator
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Looks great to me, some minor comments, let me know what you think.
Co-authored-by: Nico Matentzoglu <[email protected]>
matentzn
previously approved these changes
Aug 12, 2025
Collaborator
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Looks great! Thanks a ton!
ehartley
reviewed
Aug 17, 2025
ehartley
previously approved these changes
Aug 17, 2025
Contributor
ehartley
left a comment
ehartley
left a comment
There was a problem hiding this comment.
There is one minor typo, but otherwise everything looks good!
Co-authored-by: Emily Hartley <[email protected]>
ehartley
approved these changes
Aug 17, 2025
matentzn
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves [#477]
docs/have been added/updated if necessarymake testhas been run locallyIf you are proposing a change to the SSSOM metadata model, you must
examples/see_alsofield of the linkml modelsrc/docs/spec-models.md) accordinglyThis PR adds a new cardinality value of
0:0, to be used for mapping records where both thesubject_idand theobject_idaresssom:NoTermFound. Such records are allowed and may be used to represent the fact that there is no overlap between a subject vocabulary and an object vocabulary.The spec is updated to explain how mappings involved
sssom:NoTermFoundshould be handled when computing cardinality values.We also try to explain a bit more what the different cardinality values mean exactly, and provide two examples:
closes #477