From b3e59f06254da005bd8545acf0bfa73e7e716920 Mon Sep 17 00:00:00 2001 From: Nico Matentzoglu Date: Thu, 27 Jul 2023 11:28:08 +0300 Subject: [PATCH 1/3] Clarifying descriptions of various properties - author, reviewer and creator_id properties are clarified to be URIs, rather than "strings" - Some minor typos and rewritings --- src/sssom_schema/schema/sssom_schema.yaml | 29 ++++++++++------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/sssom_schema/schema/sssom_schema.yaml b/src/sssom_schema/schema/sssom_schema.yaml index 3a8ab1f2..f08ce749 100644 --- a/src/sssom_schema/schema/sssom_schema.yaml +++ b/src/sssom_schema/schema/sssom_schema.yaml @@ -298,40 +298,37 @@ slots: the mapping. The creator is the agent that put the mapping in its published form, which may be different from the author, which is a person that was actively involved in the assertion of the mapping. - Recommended to be a (pipe-separated) list of ORCIDs or otherwise - identifying URLs, but any identifying string (such as name and affiliation) - is permissible. + Recommended to be a list of ORCIDs or otherwise + identifying URIs. slot_uri: dcterms:creator range: EntityReference multivalued: true creator_label: description: A string identifying the creator of this mapping. In the spirit of - provenance, consider to use creator_id instead. + provenance, consider using creator_id instead. range: string multivalued: true author_id: description: Identifies the persons or groups responsible for asserting the mappings. - Recommended to be a (pipe-separated) list of ORCIDs or otherwise - identifying URLs, but any identifying string (such as name and affiliation) - is permissible. + Recommended to be a list of ORCIDs or otherwise + identifying URIs. slot_uri: pav:authoredBy range: EntityReference multivalued: true author_label: description: A string identifying the author of this mapping. In the spirit of - provenance, consider to use author_id instead. + provenance, consider using author_id instead. range: string multivalued: true reviewer_id: description: Identifies the persons or groups that reviewed and confirmed the mapping. - Recommended to be a (pipe-separated) list of ORCIDs or otherwise - identifying URLs, but any identifying string (such as name and affiliation) - is permissible. + Recommended to be a list of ORCIDs or otherwise + identifying URIs. range: EntityReference multivalued: true reviewer_label: description: A string identifying the reviewer of this mapping. In the spirit of - provenance, consider to use reviewer_id instead. + provenance, consider using reviewer_id instead. range: string multivalued: true license: @@ -354,7 +351,7 @@ slots: - value: http://purl.obolibrary.org/obo/mondo/releases/2021-01-30/mondo.owl description: (A persistent Version IRI pointing to the Mondo version '2021-01-30') object_source: - description: IRI of ontology source for the object. Version IRI preferred. + description: URI of the source vocabulary of the object. Version IRI preferred. range: EntityReference examples: - value: obo:mondo.owl @@ -415,12 +412,12 @@ slots: the match is correct, where 1 denotes total confidence. range: double subject_match_field: - description: A tuple of fields (term annotations on the subject) that was used + description: A list of properties (term annotations on the subject) that was used for the match. range: EntityReference multivalued: true object_match_field: - description: A tuple of fields (term annotations on the object) that was used + description: A list of properties (term annotations on the object) that was used for the match. range: EntityReference multivalued: true @@ -490,7 +487,7 @@ slots: range: string multivalued: true other: - description: Pipe separated list of key value pairs for properties not part of + description: List of key-value pairs for properties not part of the SSSOM spec. Can be used to encode additional provenance data. range: string comment: From cc605ff06cb23c45eae2f00869e24c2143abe730 Mon Sep 17 00:00:00 2001 From: Nico Matentzoglu Date: Thu, 27 Jul 2023 11:33:46 +0300 Subject: [PATCH 2/3] Harmonise subject and object_source descriptions --- src/sssom_schema/schema/sssom_schema.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sssom_schema/schema/sssom_schema.yaml b/src/sssom_schema/schema/sssom_schema.yaml index f08ce749..c6fa68d5 100644 --- a/src/sssom_schema/schema/sssom_schema.yaml +++ b/src/sssom_schema/schema/sssom_schema.yaml @@ -337,7 +337,7 @@ slots: range: uri slot_uri: dcterms:license subject_source: - description: URI of ontology source for the subject. + description: URI of vocabulary or identifier source for the subject. range: EntityReference examples: - value: obo:mondo.owl @@ -351,7 +351,7 @@ slots: - value: http://purl.obolibrary.org/obo/mondo/releases/2021-01-30/mondo.owl description: (A persistent Version IRI pointing to the Mondo version '2021-01-30') object_source: - description: URI of the source vocabulary of the object. Version IRI preferred. + description: URI of vocabulary or identifier source for the object. range: EntityReference examples: - value: obo:mondo.owl From c29d59965882a365456a9a044d0a0c25c1a20fad Mon Sep 17 00:00:00 2001 From: Nico Matentzoglu Date: Thu, 27 Jul 2023 16:05:36 +0300 Subject: [PATCH 3/3] Reverts description of "other" slot This needs to be dealt with in in https://github.com/mapping-commons/sssom/pull/263 --- src/sssom_schema/schema/sssom_schema.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sssom_schema/schema/sssom_schema.yaml b/src/sssom_schema/schema/sssom_schema.yaml index c6fa68d5..7e533c61 100644 --- a/src/sssom_schema/schema/sssom_schema.yaml +++ b/src/sssom_schema/schema/sssom_schema.yaml @@ -487,7 +487,7 @@ slots: range: string multivalued: true other: - description: List of key-value pairs for properties not part of + description: Pipe separated list of key value pairs for properties not part of the SSSOM spec. Can be used to encode additional provenance data. range: string comment: