Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions would be nice #1

Open
rtaylorzfin opened this issue Jun 7, 2024 · 4 comments
Open

Instructions would be nice #1

rtaylorzfin opened this issue Jun 7, 2024 · 4 comments

Comments

@rtaylorzfin
Copy link

Hi,

Thanks for writing this validation library. Could you include instructions on how to use it? I have some sssom files that I would like to validate.

Thanks,
Ryan

@matentzn
Copy link
Contributor

@rtaylorzfin Thank you for reaching out!

I would recommend the following:

  1. For simple command line usage do
pip install sssom
sssom validate my.sssom.tsv

For Continuous Integration I would recommand setting up a Mapping Registry which comes with a GitHub action that will do the checking for you whenever you make a pull request (see action here).

The repo you found here is a bad attempt of me to write a webtool for validating SSSOM. Something like https://jsonlint.com/ for sssom files. Would you still be interested in this?

@rtaylorzfin
Copy link
Author

@matentzn
Thanks for the reply. The command line tool is great. Thanks!

@matentzn
Copy link
Contributor

I would be amiss to say that the validator does not catch all important errors.

Please feel free to open issues to things you think are wrong and should be validated.

Also, for a well rounded picture, we use

  1. tsvalid to check for basic TSV issues like redundant whitespace
  2. do a test conversion into RDF
  3. run sssom validate

(https://github.com/monarch-initiative/monarch-mapping-commons/blob/62a76081a4cf326ee7fc48add6d2bb9439b30a22/Makefile#L43)

All of these should give you a good level of security. Looking forward to your issues!

@rtaylorzfin
Copy link
Author

Great tips! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants