Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestWrite.test_missing_entries() #534

Open
joeflack4 opened this issue May 20, 2024 · 2 comments · May be fixed by #533
Open

TestWrite.test_missing_entries() #534

joeflack4 opened this issue May 20, 2024 · 2 comments · May be fixed by #533
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@joeflack4
Copy link
Collaborator

joeflack4 commented May 20, 2024

Overview

Addresses part of #513. Creates a test to check for missing entries in prefix_map / curie_map after initializing MappingSetDataFrame.

@joeflack4 joeflack4 self-assigned this May 20, 2024
@joeflack4 joeflack4 added bug Something isn't working enhancement New feature or request labels May 20, 2024
@matentzn
Copy link
Collaborator

Can you give more detail here? What exactly is missing and why?

@joeflack4
Copy link
Collaborator Author

Looks like I accidentally wrote "Addresses part of #533", but meant to write "Addresses part of #513". The detail is in that issue, #513.

I don't remember why I felt the need to create a sub-issue for this test.

In any case, to summarize #513, basically I noticed that, even though I had icd11.foundation in the curie_map in my metadata .yml, and in at least 1 of the rows in my mapping set, it was not showing up in the curie_map in the metadata comment when I wrote to TSV.

@joeflack4 joeflack4 linked a pull request May 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants