-
-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct mouse position even when scaling the map using CSS #3437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3437 +/- ##
==========================================
+ Coverage 75.60% 75.61% +0.01%
==========================================
Files 243 243
Lines 19163 19172 +9
Branches 4243 4246 +3
==========================================
+ Hits 14488 14497 +9
Misses 4675 4675 ☔ View full report in Codecov by Sentry. |
8 tasks
neodescis
reviewed
Dec 3, 2023
neodescis
reviewed
Dec 3, 2023
Co-authored-by: neodescis <[email protected]>
Co-authored-by: neodescis <[email protected]>
neodescis
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1160
Replaces
The reason for changing to use canvas instead of canvas container for mouse positions is the following - the height of the container is 0, which doesn't allow to calculate the relative change in height.
CHANGELOG.md
under the## main
section.