From 758b3457dbe4e10821dfd39ae5ed6c0a6721e9c9 Mon Sep 17 00:00:00 2001 From: Nick Steinbaugh Date: Fri, 26 May 2023 08:51:20 -0600 Subject: [PATCH 1/3] Fix typing error when consuming maplibre-gl with TypeScript compiler set to strict mode --- CHANGELOG.md | 2 +- src/gl/value.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 28dc1a24001..8d4af1ad4d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ ### 🐞 Bug fixes - Fix `RequestTransformFunction` type to return RequestParameters or undefined ([#2586](https://github.com/maplibre/maplibre-gl-js/pull/2586)) - Load `EXT_color_buffer_float` WebGL2 extension to fix heatmap in firefox ([#2595](https://github.com/maplibre/maplibre-gl-js/pull/2595)) - +- Fix typing error when consuming maplibre-gl with TypeScript compiler set to strict mode ## 3.0.0 diff --git a/src/gl/value.ts b/src/gl/value.ts index 8f21e6bb7b5..a7d860d81c5 100644 --- a/src/gl/value.ts +++ b/src/gl/value.ts @@ -418,7 +418,7 @@ export class BindElementBuffer extends BaseValue { } export class BindVertexArray extends BaseValue { - getDefault(): WebGLVertexArrayObject | null { + getDefault(): WebGLVertexArrayObject { return null; } set(v: WebGLVertexArrayObject | null) { From 7dcd2458d587f594a2b155727767df57af119f6d Mon Sep 17 00:00:00 2001 From: Nick Steinbaugh Date: Fri, 26 May 2023 08:56:14 -0600 Subject: [PATCH 2/3] Update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8d4af1ad4d5..8082d2b75ba 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,7 @@ ### 🐞 Bug fixes - Fix `RequestTransformFunction` type to return RequestParameters or undefined ([#2586](https://github.com/maplibre/maplibre-gl-js/pull/2586)) - Load `EXT_color_buffer_float` WebGL2 extension to fix heatmap in firefox ([#2595](https://github.com/maplibre/maplibre-gl-js/pull/2595)) -- Fix typing error when consuming maplibre-gl with TypeScript compiler set to strict mode +- Fix typing error when consuming maplibre-gl with TypeScript compiler set to strict mode ([#2600](https://github.com/maplibre/maplibre-gl-js/pull/2600)) ## 3.0.0 From 2b9164c14fa4687cf073adcf48c74df70cb94506 Mon Sep 17 00:00:00 2001 From: Nick Steinbaugh Date: Fri, 26 May 2023 12:28:22 -0600 Subject: [PATCH 3/3] Remove changelog entry --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8082d2b75ba..d3e9c423bc5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,6 @@ ### 🐞 Bug fixes - Fix `RequestTransformFunction` type to return RequestParameters or undefined ([#2586](https://github.com/maplibre/maplibre-gl-js/pull/2586)) - Load `EXT_color_buffer_float` WebGL2 extension to fix heatmap in firefox ([#2595](https://github.com/maplibre/maplibre-gl-js/pull/2595)) -- Fix typing error when consuming maplibre-gl with TypeScript compiler set to strict mode ([#2600](https://github.com/maplibre/maplibre-gl-js/pull/2600)) ## 3.0.0