DoubleClick/DoubleTap zooms don't disable

[zta6]

maplibre-gl-js version: 2.4.0

browser: Chrome

Steps to Trigger Behavior

1. map.doubleClickZoom.disable(), map.doubleClickZoom.isEnabled() returns false
2. double click the map. See that it still zooms
3. map.doubleClickZoom.isEnabled() returns true. Double clicking re-enables the double click zoom action.

Link to Demonstration

Expected Behavior

Double Click Zoom is disabled when disable() is called

Actual Behavior

Double click zoom is not disabled.

There is a mapbox bug for this: mapbox/mapbox-gl-draw#691

[HarelM]

Thanks for taking the time to report this issue!
Can you please add a jsbin/stackblitz/codepen reproduction?

[Chaitu-Tatipamula]

can i work on this

[HarelM]

Sure! Go ahead!

[zta6]

Update: much like the mapbox bug, this seems to only occur when mapbox-draw is added. So perhaps the issue isn't on MapLibre's side?

But it looks like this PR: mapbox/mapbox-gl-draw#696 is supposedly the one that fixed the bug in mapbox-draw. And that was in 1.0.4. I'm on mapbox-draw 1.4.1 and still seeing this.

[zta6]

this may be the source: https://github.com/mapbox/mapbox-gl-draw/blob/main/src/modes/simple_select.js#L137 ??

[HarelM]

If this is still relevant I'll be happy to reopen this issue.
Closing for now.

[cckolon]

I'm still seeing this in mapbox-gl v 3.2.0 and with mapbox-gl-draw v 1.4.3. Disabling double click zoom works without the draw component, but fails with the draw component added. Disabling on load worked in my case, but this is still definitely an issue.