Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the GeoJSON / MVT 2.0 "id" field? #274

Closed
anandthakker opened this issue Jul 15, 2016 · 5 comments
Closed

Support the GeoJSON / MVT 2.0 "id" field? #274

anandthakker opened this issue Jul 15, 2016 · 5 comments

Comments

@anandthakker
Copy link
Contributor

While I'm sure that the full v2.0 of the vector tile spec would be a big project, I wonder if it would be possible for tippecanoe to support the optional "id" property for vector tile features, based upon the equivalent property for geojson feature objects?

Raising this in anticipation of mapbox/mapbox-gl-style-spec#391 and mapbox/mapbox-gl-js#2874
@e-n-f
Copy link
Contributor

e-n-f commented Jul 15, 2016

Oh sure, I can add that. Thanks for pointing out the omission.

@anandthakker
Copy link
Contributor Author

👍 thanks!

@e-n-f
Copy link
Contributor

e-n-f commented Jul 15, 2016

I think #275 should take care of this. Please give it a try and see if it works for you.

@e-n-f e-n-f closed this as completed Jul 15, 2016
@e-n-f
Copy link
Contributor

e-n-f commented Jul 15, 2016

Please also sync #276 which fixes a typo that would make it do the wrong thing if you had both an ID and a per-feature minzoom.

@anandthakker
Copy link
Contributor Author

Ah -- thanks for the heads up!

On Fri, Jul 15, 2016 at 6:42 PM Eric Fischer [email protected]
wrote:

Please also sync #276 #276
which fixes a typo that would make it do the wrong thing if you had both an
ID and a per-feature minzoom.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#274 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEvmR1luZlT2TmmkxXdJ2nNNZyku-pWHks5qWAzhgaJpZM4JNvAm
.

ewsterrenburg pushed a commit to ewsterrenburg/tippecanoe that referenced this issue Dec 5, 2024
@e-n-f
Another round of binning fixes (mapbox#274)
66e5d66 
* Bin more aggressively if a point doesn't meet the pnpoly test

* Don't clip the points if we are binning

* Fix output of features added to the bin after its closure

* Update tests

* Update version and changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@e-n-f @anandthakker