Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding SpeechOptions URL query parameters #50

Open
1ec5 opened this issue Mar 24, 2022 · 0 comments
Open

Allow overriding SpeechOptions URL query parameters #50

1ec5 opened this issue Mar 24, 2022 · 0 comments

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 24, 2022

SpeechOptions.path and SpeechOptions.params are internal. We should rename them to abridgedPath and urlQueryItems, respectively, and make them open, for consistency with RouteOptions in MapboxDirections. This will enable developers to pass in additional settings that aren’t supported by this library, such as beta parameters that it can’t support due to backwards compatibility concerns.

internal var params: [URLQueryItem] {

/ref mapbox/mapbox-directions-swift#343 mapbox/mapbox-directions-swift#461
/cc @mapbox/navigation-ios @browndp08 @Guardiola31337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant