You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SpeechOptions.path and SpeechOptions.params are internal. We should rename them to abridgedPath and urlQueryItems, respectively, and make them open, for consistency with RouteOptions in MapboxDirections. This will enable developers to pass in additional settings that aren’t supported by this library, such as beta parameters that it can’t support due to backwards compatibility concerns.
SpeechOptions.path
andSpeechOptions.params
are internal. We should rename them toabridgedPath
andurlQueryItems
, respectively, and make themopen
, for consistency withRouteOptions
in MapboxDirections. This will enable developers to pass in additional settings that aren’t supported by this library, such as beta parameters that it can’t support due to backwards compatibility concerns.mapbox-speech-swift/Sources/MapboxSpeech/MBSpeechOptions.swift
Line 65 in b0a6008
mapbox-speech-swift/Sources/MapboxSpeech/MBSpeechOptions.swift
Line 74 in b0a6008
/ref mapbox/mapbox-directions-swift#343 mapbox/mapbox-directions-swift#461
/cc @mapbox/navigation-ios @browndp08 @Guardiola31337
The text was updated successfully, but these errors were encountered: