Revert breaking changes related to shields from maneuvers

[abhishek1508]

Description

Fixes #5302

Screenshots or Gifs

[LukasPaczos]

There's a

        userId: String?,
        styleId: String?,
        accessToken: String?,
        maneuvers: List<Maneuver>,
        callback: RoadShieldCallback
    ) {

that we've made public but it's immediately deprecated. Let's make it internal.

[abhishek1508]

There's a

        userId: String?,
        styleId: String?,
        accessToken: String?,
        maneuvers: List<Maneuver>,
        callback: RoadShieldCallback
    ) {

that we've made public but it's immediately deprecated. Let's make it internal.

If we make this API internal, how would an end user request mapbox designed shield using deprecated RoadShieldCallback?

[LukasPaczos]

If we make this API internal, how would an end user request mapbox designed shield using deprecated RoadShieldCallback?

Couldn't they use the new callback instead? They need to make changes to pass in the style id, user, and token, so why not migrate to the new API altogether?

[abhishek1508]

Couldn't they use the new callback instead? They need to make changes to pass in the style id, user, and token, so why not migrate to the new API altogether?

Okay so if I make

fun getRoadShields(
        userId: String?,
        styleId: String?,
        accessToken: String?,
        maneuvers: List<Maneuver>,
        callback: RoadShieldCallback
    )

internal, then that means as a user if you continue to use the deprecated API, you cannot request mapbox designed shields because that API is internal. To be able to use mapbox designed shield migrate to new API. Is that correct?
@LukasPaczos

[LukasPaczos]

To be able to use mapbox designed shield migrate to new API. Is that correct?

Exactly.

[LukasPaczos]

nit: we can keep logging the error here

[LukasPaczos]

LGTM with one suggestion.