Provide default LocationComponent style when not found #1696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
===========================================
- Coverage 29.22% 29.2% -0.02%
Complexity 810 810
===========================================
Files 202 202
Lines 7898 7902 +4
Branches 618 619 +1
===========================================
Hits 2308 2308
- Misses 5369 5373 +4
Partials 221 221 |
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
I left a couple of minor comments. As soon as the conflicts from master are fixed we can merge here.
Thanks for the quick fix @danesfeder
| private static final String TRAFFIC_LAYER_ID = "traffic"; | ||
| private static final int[] ZERO_MAP_PADDING = {0, 0, 0, 0}; | ||
| private static final double NAVIGATION_MAXIMUM_MAP_ZOOM = 18d; | ||
| private static final int INVLAID_LAYER_STYLE = 0; |
Contributor
There was a problem hiding this comment.
Typo *INVLAID_LAYER_STYLE 👉 INVALID
| private int findLayerStyleRes(Context context) { | ||
| int locationLayerStyleRes = ThemeSwitcher.retrieveNavigationViewStyle(context, | ||
| R.attr.navigationViewLocationLayerStyle); | ||
| if (locationLayerStyleRes == INVLAID_LAYER_STYLE) { |
Contributor
There was a problem hiding this comment.
Should we rely on this https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/content/res/ResourceId.java#38 instead?
Contributor
There was a problem hiding this comment.
Previous comment #1696 (comment) won't apply if we implement this.
danesfeder
force-pushed
the
dan-map-style-handle
branch
2 times, most recently
from
f07f10d to
353ecb3
Compare
danesfeder
force-pushed
the
dan-map-style-handle
branch
from
353ecb3 to
5591a8a
Compare
Guardiola31337
approved these changes
Jan 25, 2019
Contributor
Guardiola31337
left a comment
Guardiola31337
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback @danesfeder
danesfeder
force-pushed
the
dan-map-style-handle
branch
from
5591a8a to
d8384bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1692
We were assuming a style was being provided for the
LocationComponentwhen it's possible for developers to use theNavigationMapboxMapoutside of theNavigationViewcontext.