Skip to content

Return the actual error coming back from NN when fetching an offline route fails #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2019
Merged

Return the actual error coming back from NN when fetching an offline route fails #1660

merged 1 commit into from
Jan 10, 2019

Conversation

@Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Jan 10, 2019

  • Returns the actual error coming back from NN when fetching an offline route fails, adding something which has more information to help which will definitely help diagnose potential fetching issues

cc @kevinkreiser

@Guardiola31337 Guardiola31337 added this to the v0.27.0 milestone Jan 10, 2019
@Guardiola31337 Guardiola31337 self-assigned this Jan 10, 2019
@Guardiola31337 Guardiola31337 force-pushed the pg-return-offline-error-from-nn branch from 53f9d41 to 092f0cb Compare January 10, 2019 13:53
danesfeder
danesfeder approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Guardiola31337 🚢

@codecov-io
Copy link

codecov-io commented Jan 10, 2019 •
edited
Loading

Codecov Report

Merging #1660 into master will increase coverage by 0.24%.
The diff coverage is 80%.

@@             Coverage Diff             @@
##             master   #1660      +/-   ##
===========================================
+ Coverage     26.25%   26.5%   +0.24%     
- Complexity      787     795       +8     
===========================================
  Files           197     197              
  Lines          8384    8392       +8     
  Branches        602     602              
===========================================
+ Hits           2201    2224      +23     
+ Misses         5983    5968      -15     
  Partials        200     200

@Guardiola31337 Guardiola31337 force-pushed the pg-return-offline-error-from-nn branch from 092f0cb to c83b45e Compare January 10, 2019 15:52
@Guardiola31337 Guardiola31337 force-pushed the pg-return-offline-error-from-nn branch from c83b45e to 124f6ec Compare January 10, 2019 15:54
@Guardiola31337 Guardiola31337 merged commit 5cc556e into master Jan 10, 2019
@Guardiola31337 Guardiola31337 deleted the pg-return-offline-error-from-nn branch January 10, 2019 16:13
@danesfeder danesfeder mentioned this pull request Jan 16, 2019
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danesfeder danesfeder danesfeder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Guardiola31337 Guardiola31337

Labels

None yet

Projects

None yet

Milestone

v0.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Guardiola31337 @codecov-io @danesfeder